Add Parameter socket_options to HTTPXRequest#3935
Merged
Bibo-Joshi merged 5 commits intomasterfrom Oct 22, 2023
Merged
Conversation
tsnoam
approved these changes
Oct 21, 2023
Member
tsnoam
left a comment
There was a problem hiding this comment.
lgtm.
still, check the comments. you might want to address some of them.
harshil21
approved these changes
Oct 22, 2023
Bibo-Joshi
added a commit
that referenced
this pull request
Oct 23, 2023
* Follow up for #3935 * Also adds tests that make sure that `ApplicationBuilder` has all necessary methods
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2965
TBH I'm not quite sure if I got the parameter description right, as I've never really worked with socket options. @tsnoam if you could kindly have a look at the descrption, that would be a great help :)