Rename Parameter proxy_url to proxy and Support httpx.Proxy as Input#3939
Merged
Bibo-Joshi merged 6 commits intomasterfrom Oct 23, 2023
Merged
Rename Parameter proxy_url to proxy and Support httpx.Proxy as Input#3939Bibo-Joshi merged 6 commits intomasterfrom
proxy_url to proxy and Support httpx.Proxy as Input#3939Bibo-Joshi merged 6 commits intomasterfrom
Conversation
tsnoam
approved these changes
Oct 22, 2023
Member
tsnoam
left a comment
There was a problem hiding this comment.
lgtm. see comments if you care to change anything.
Comment on lines
+96
to
+97
| * For Socks5 support, additional dependencies are required. Make sure to install | ||
| PTB via :command:`pip install "python-telegram-bot[socks]"` in this case. |
Member
There was a problem hiding this comment.
Suggested change
| * For Socks5 support, additional dependencies are required. Make sure to install | |
| PTB via :command:`pip install "python-telegram-bot[socks]"` in this case. | |
| * For Socks5 support, additional dependencies are required. They can be installed using the | |
| command :command:`pip install "python-telegram-bot[socks]"`. |
# Conflicts: # telegram/request/_httpxrequest.py
harshil21
requested changes
Oct 22, 2023
Member
Author
Sorry, hadn't seen this. Will change appbilder. PTB warnings are explicitly ignored in |
clot27
reviewed
Oct 23, 2023
harshil21
requested changes
Oct 23, 2023
Member
harshil21
left a comment
There was a problem hiding this comment.
Tests look good, just some typos:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3844