Improve write_timeout Handling for Media Methods#3952
Merged
Bibo-Joshi merged 5 commits intomasterfrom Nov 26, 2023
Merged
Conversation
* implement deprecation layer in `BaseRequest` * implement hard-coded handling in `HTTPXRequset` * Add deprecation notices to docs
This was referenced Nov 4, 2023
# Conflicts: # docs/auxil/kwargs_insertion.py
harshil21
reviewed
Nov 20, 2023
Member
harshil21
left a comment
There was a problem hiding this comment.
logic looks good, just few minor comments
harshil21
approved these changes
Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second part of #3864
Unfortunately I realised that the approach outlined in #3864 is not as backward compatible as I initially thought, but I think I found a rather clean deprecation layer
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSIONor.. deprecated:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__Added myself alphabetically toAUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior