Add Missing Conversions of type to Corresponding Enum from telegram.constants#4067
Merged
Bibo-Joshi merged 2 commits intomasterfrom Jan 17, 2024
Merged
Add Missing Conversions of type to Corresponding Enum from telegram.constants#4067Bibo-Joshi merged 2 commits intomasterfrom
type to Corresponding Enum from telegram.constants#4067Bibo-Joshi merged 2 commits intomasterfrom
Conversation
harshil21
reviewed
Jan 17, 2024
Member
harshil21
left a comment
There was a problem hiding this comment.
yeah, I had seen some places where this was missed. Is there a way to easily test this for all classes (test should probably assume that self.type needs an enum reference)
Member
Author
|
Added a simple regex testcase and actually found another place to apply the change. I excluded passport stuff - we don't have enums for that and I don't like touching that stuff if not really necessary 😬 |
harshil21
approved these changes
Jan 17, 2024
Member
harshil21
left a comment
There was a problem hiding this comment.
The general test case looks good and I'm fine with excluding the passport directory!
kenjitagawa
pushed a commit
to kenjitagawa/python-telegram-bot
that referenced
this pull request
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.