Call Application.post_stop Only if Application.stop was called#4211
Merged
Bibo-Joshi merged 24 commits intomasterfrom May 20, 2024
Merged
Call Application.post_stop Only if Application.stop was called#4211Bibo-Joshi merged 24 commits intomasterfrom
Application.post_stop Only if Application.stop was called#4211Bibo-Joshi merged 24 commits intomasterfrom
Conversation
This reverts commit a60b7d3.
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
harshil21
reviewed
May 20, 2024
harshil21
approved these changes
May 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
# Conflicts: # telegram/ext/_application.py # tests/ext/test_application.py
Bibo-Joshi
commented
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to be merged (and possibly reviewed) after #4157. based this PR on the branch of #4157 since the bug mostly becomes visible after those changes.
closes #4210