Conversation
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Hey : ) I noticed the "WIP" label too late, so here you already have somen comment 😅
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Hey, thanks for the updates! I went throug the new changes and admittedly only skimmed the tests 😅
I left a few more comments
|
|
||
| def test_to_dict(self, star_transaction): | ||
| def test_to_dict(self): | ||
| st = star_transaction() |
There was a problem hiding this comment.
did you mean to use this as fixuter instead, i.e. pass it as argument? same in the other tests
There was a problem hiding this comment.
I had done that before but I actually wanted to use the return value in TestStarTransactionsBase, so I kept it as a function
There was a problem hiding this comment.
Mh, I see. Might something like this be of use? https://stackoverflow.com/a/63047695/10606962
I'm okay with keeping as is, but it's at least something that future-us will likely stumble over if we have re-touch tests.
Bibo-Joshi
left a comment
There was a problem hiding this comment.
LGTM just left me know if you want to change something about the tests or keep it as is :)
|
I'll keep the tests as is for now. |
Checklist
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSIONor.. deprecated:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__AUTHORS.rst(optional)__all__sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behaviorIf the PR contains API changes (otherwise, you can ignore this passage)
Checked the Bot API specific sections of the Stability Policy
New classes:
self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas kw-onlyAdded new shortcuts:
~telegram.Chat& :class:~telegram.Userfor all methods that acceptchat/user_id~telegram.Messagefor all methods that acceptchat_idandmessage_id~telegram.Messageshortcuts: Addeddo_quoteargument if methods acceptsreply_to_message_id~telegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablestelegram.Message.effective_attachment~telegram.ext.ConversationHandler_extbot.pybot_methods.rstREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION_INFOtelegram.ext.ExtBotfor new methods that either accept areply_markupin some form or have a return type that is/contains :class:~telegram.Message