Merged
Conversation
Member
Author
|
todo: make bot arg of de_json optional in the new classes here |
Bibo-Joshi
approved these changes
Jul 1, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Skimmed the changes again and didn't find anything else. Also checked the test-official run and found only 7.6 related errors.
@harshil21 if you have no further comments, I'd like to merge so that we have as few merge conflicts with API 7.6 as possible :)
Member
Author
|
looks good to me as well. Tests failing due to an unrelated reason it seems (github actions logs takes much longer to load now..). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4310
Gathering all PR's to close this.
#4311 #4315 #4328 #4316