Conversation
Bibo-Joshi
approved these changes
Jun 28, 2024
Bibo-Joshi
requested changes
Jun 28, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Upsie, no, pre-commit is failing I should not approve that :D
Member
Author
the ruff fix for job queue is probably going to break the type completeness again, do you want to ignore it? |
Changes print statements in passportbot to logger statements (UNTESTED)
| for data in passport_data.decrypted_data: # This is where the data gets decrypted | ||
| if data.type == "phone_number": | ||
| print("Phone: ", data.phone_number) | ||
| logger.info("Phone: %s", data.phone_number) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
Member
There was a problem hiding this comment.
Huh, first time I see this security feature doing something:D
Bibo-Joshi
approved these changes
Jun 30, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Anything left from your side?
Member
Author
|
all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wake up, new ruff just dropped!
new rules added: