Merged
Conversation
Closed
2 tasks
harshil21
requested changes
Jul 7, 2024
Member
harshil21
left a comment
There was a problem hiding this comment.
readme.rst needs updating but otherwise looks good!
Comment on lines
+582
to
+583
| about a refunded payment, information about the payment. | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| about a refunded payment, information about the payment. | |
| about a refunded payment, information about the payment. | |
| .. seealso:: | |
| `Telegram Docs on payments <https://core.telegram.org/bots/api#payments>`_ |
Member
Author
There was a problem hiding this comment.
While we could definitely add this, it would also need to be added to successful_payment and paid_media.
All of them getting this big block might take up unnecessary amount of screen time, I would do an inline link then instead
Member
There was a problem hiding this comment.
hmm I was just following what hinrich started with 027263a, inline link also works with me
Member
Author
Comment on lines
+904
to
+905
| about a refunded payment, information about the payment. | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| about a refunded payment, information about the payment. | |
| about a refunded payment, information about the payment. | |
| .. seealso:: | |
| `Telegram Docs on payments <https://core.telegram.org/bots/api#payments>`_ |
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
harshil21
reviewed
Jul 7, 2024
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Bibo-Joshi
approved these changes
Jul 8, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
thanks for the quick PR! one pre-commit finding. test failures seem unrelated
harshil21
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.