Make Tests for telegram.ext Independent of Networking#4454
Make Tests for telegram.ext Independent of Networking#4454Bibo-Joshi merged 7 commits intomasterfrom
telegram.ext Independent of Networking#4454Conversation
By cutting of the internet connection in the fixtures
harshil21
left a comment
There was a problem hiding this comment.
Alright, looks good to me. Regarding the WithoutRequest tests, after we use offline_bot there as well, I'm wondering if we can disallow the bot fixture to be used in those tests. As you mentioned, it's close to impossible to effectively enforce this, but it's a decent try.
We can get the fixture list using fixturenames it seems.
I would like to move this to a different PR … |
|
All right. Looks like I've got all tests working by now and also managed to reduce repetitions a bit. So now actually ready for review 😅 |
By cutting of the internet connection in the fixtures
offline_botthat has no internet connectionextto have no internet connectionLet's see if I got everything in local testing
supersedes #4317. Although this PR here doesn't cover cutting off the internet connection in the
*WithoutRequesttests, I don't think I'll follow up on that for the reasons pointed out in #4317.