Skip to content

Add chango For Changelog Management Tool#4672

Merged
Bibo-Joshi merged 12 commits intomasterfrom
chango
Mar 1, 2025
Merged

Add chango For Changelog Management Tool#4672
Bibo-Joshi merged 12 commits intomasterfrom
chango

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Feb 6, 2025

When merged, closes #4321.
This is an initial setup. There are probably things to improve both in how PTB uses chango and in the feature set of chango itself.
But it can already generate the changelogs, so that's mature enough to get started :)

Should be merged directly after we make a release, so that we have a clean start

Let's hope that I got all the CI config right and this doesn't become an embarrassment xD

@Bibo-Joshi Bibo-Joshi added ⚙️ documentation affected functionality: documentation 📋 do-not-merge-yet work status: do-not-merge-yet ⚙️ ci-cd affected functionality: ci-cd labels Feb 6, 2025
@Bibo-Joshi Bibo-Joshi added the ℹ️ needs-wiki-update information: needs-wiki-update label Feb 7, 2025
harshil21
harshil21 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looking forward to see how much easier changelog generation becomes

Poolitzer
Poolitzer approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this is exciting

@Bibo-Joshi
Copy link
Member Author

Bibo-Joshi commented Feb 8, 2025

🥳
If I have time before the next release, I'll update this PR to change the content of the GitHub release. At least for the start, I'll just point to the changelog on docs.ptb.org - that also gives us a single source of thruth. Possibly I'll also include a step that sends a similar message to the channel.

@Bibo-Joshi
Copy link
Member Author

Bibo-Joshi commented Feb 9, 2025

I'll update this PR to change the content of the GitHub release. At least for the start, I'll just point to the changelog on docs.ptb.org - that also gives us a single source of thruth. Possibly I'll also include a step that sends a similar message to the channel.

Done that. I've tested locally that the sed-ing and sending message via curl works. That should suffice hopefully. In the worst case the creating of github release or tg channel post fail on the first release after merging this. But the pypi release won't be affected and GH release & Channel post can be created manually if needed. The sigstore artifacts are uploaded to the workflow attchments, so even those won't get lost.

@harshil21 harshil21 requested a review from Copilot February 26, 2025 18:23
Copilot AI reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Bibo-Joshi and others added 2 commits February 26, 2025 20:58
@Bibo-Joshi
fix a typo
6b9dfef 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Bibo-Joshi
update faulty label config
2c5e3d0
@codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
6520 1 6519 788
View the top 1 failed test(s) by shortest run time 
tests.test_bot.TestBotWithRequest::test_send_close_date_default_tz[UTC-ZoneInfo]
Stack Traces | 5.28s run time 
self = <tests.test_bot.TestBotWithRequest object at 0x000001B68E37A7C0>
tz_bot = PytestExtBot[token=671468886:AAGPGfciRIBUNFe824uIVdq7Je3_YnATNGw]
super_group_id = '-1001446022522'

    async def test_send_close_date_default_tz(self, tz_bot, super_group_id):
        question = "Is this a test?"
        answers = ["Yes", "No", "Maybe"]
        reply_markup = InlineKeyboardMarkup.from_button(
            InlineKeyboardButton(text="text", callback_data="data")
        )
    
        aware_close_date = dtm.datetime.now(tz=tz_bot.defaults.tzinfo) + dtm.timedelta(seconds=5)
        close_date = aware_close_date.replace(tzinfo=None)
    
        msg = await tz_bot.send_poll(  # The timezone returned from this is always converted to UTC
            chat_id=super_group_id,
            question=question,
            options=answers,
            close_date=close_date,
            read_timeout=60,
        )
        msg.poll._unfreeze()
        # Sometimes there can be a few seconds delay, so don't let the test fail due to that-
>       msg.poll.close_date = msg.poll.close_date.astimezone(aware_close_date.tzinfo)
E       AttributeError: 'NoneType' object has no attribute 'astimezone'

tests\test_bot.py:2843: AttributeError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Bibo-Joshi Bibo-Joshi merged commit 76d8eaf into master Mar 1, 2025
27 checks passed
@Bibo-Joshi Bibo-Joshi deleted the chango branch March 1, 2025 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harshil21 harshil21 harshil21 approved these changes

Copilot code review Copilot Copilot left review comments

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees

No one assigned

Labels

⚙️ ci-cd affected functionality: ci-cd 📋 do-not-merge-yet work status: do-not-merge-yet ⚙️ documentation affected functionality: documentation ℹ️ needs-wiki-update information: needs-wiki-update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New way to manage & structure release notes

3 participants

@Bibo-Joshi @Poolitzer @harshil21

Comments