Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Python 3.14 beta by updating configuration files and dependency lists, ensuring compatibility with the latest version. Key changes include updating the pytest distributed execution option in the tests documentation, modifying dependency definitions in pyproject.toml to include Python 3.14–specific variants (including a temporary pydantic dependency and retaining pytz for testing), and updating the GitHub workflow to include a Python 3.14 beta version in the testing matrix.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/README.rst | Updated pytest-xdist option from "--dist=loadgroup" to "--dist=worksteal". |
| pyproject.toml | Added Python 3.14 classifier and adjusted dependency definitions for new version support. |
| .github/workflows/unit_tests.yml | Included Python 3.14 beta in the test matrix and removed manual installation of pytz. |
Comments suppressed due to low confidence (3)
tests/README.rst:45
- [nitpick] Ensure that the use of '--dist=worksteal' is supported by the installed version of pytest-xdist and that any relevant documentation is updated accordingly.
$ pytest -n auto --dist=worksteal
pyproject.toml:116
- [nitpick] Consider clarifying this comment to indicate that pytz is retained solely for backward compatibility in testing, helping users understand its role despite deprecation elsewhere.
# We've deprecated support pytz, but we still need it for testing that it works with the library.
.github/workflows/unit_tests.yml:64
- After removing the manual installation of pytz, please verify that all testing environments receive the correct dependencies so tests relying on pytz pass reliably.
# need to manually install pytz here, because it's no longer in the optional reqs
Bibo-Joshi
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds pytz to the test dependency group since it was impossible to run the test suite without it.
Tested locally with uv's python 3.14, and with JIT enabled. Also confirmed that test official passes on 3.14 with the changes to annotations.