API 9.1 InputChecklist[Task] classes and bot.send/edit_checklist#4857
Merged
Bibo-Joshi merged 8 commits intoapi-9.1from Jul 16, 2025
Merged
API 9.1 InputChecklist[Task] classes and bot.send/edit_checklist#4857Bibo-Joshi merged 8 commits intoapi-9.1from
InputChecklist[Task] classes and bot.send/edit_checklist#4857Bibo-Joshi merged 8 commits intoapi-9.1from
Conversation
aelkheir
commented
Jul 8, 2025
Comment on lines
+3964
to
+3967
| Note: | ||
| You can only edit messages that the bot sent itself (i.e. of the ``bot.send_*`` family | ||
| of methods) or channel posts, if the bot is an admin in that channel. However, this | ||
| behaviour is undocumented and might be changed by Telegram. |
Member
Author
There was a problem hiding this comment.
Was hesitant about this note section, whether it's relevant here, should be removed entirely, or made to say something like:
Suggested change
| Note: | |
| You can only edit messages that the bot sent itself (i.e. of the ``bot.send_*`` family | |
| of methods) or channel posts, if the bot is an admin in that channel. However, this | |
| behaviour is undocumented and might be changed by Telegram. | |
| Note: | |
| You can only edit messages that the bot sent itself (i.e. of the ``bot.send_*`` family | |
| of methods). However, this | |
| behaviour is undocumented and might be changed by Telegram. |
It exists in most, if not all, other Message.edit_ shortcuts
Member
There was a problem hiding this comment.
If the text is mostly the same everywhere, I'd vote to keep it like that just for consistency :)
Bibo-Joshi
reviewed
Jul 15, 2025
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the nice PR and please excuse the late review :/ Not much to comment, you thought of everything IISC 🥳
Comment on lines
+3964
to
+3967
| Note: | ||
| You can only edit messages that the bot sent itself (i.e. of the ``bot.send_*`` family | ||
| of methods) or channel posts, if the bot is an admin in that channel. However, this | ||
| behaviour is undocumented and might be changed by Telegram. |
Member
There was a problem hiding this comment.
If the text is mostly the same everywhere, I'd vote to keep it like that just for consistency :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check-list for PRs
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSIONor ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)__all__sIf the PR contains API changes (otherwise, you can ignore this passage)Checked the Bot API specific sections of the Stability Policy
Created a PR to remove functionality deprecated in the previous Bot API release (see here)
New Classes
self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas keyword-onlyAdded New Shortcuts
telegram.Chat&telegram.Userfor all methods that acceptchat/user_idtelegram.Messagefor all methods that acceptchat_idandmessage_idtelegram.Messageshortcuts: Addedquoteargument if methods acceptreply_to_message_idtelegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf Relevant
telegram.constantsand shortcuts to them as class variablestelegram.Message.effective_attachmenttelegram.ext.ConversationHandler_extbot.pybot_methods.rstREADME.rst(including the badge) andtelegram.constants.BOT_API_VERSION_INFOtelegram.ext.ExtBotfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.MessageAPI 9.1 Items:
I've skipped
parse_entityutility methods for the classesInputChecklist[Task]as they're implemented on the returned version of the classes, and don't make much sense here imo.