Conversation
Bibo-Joshi
left a comment
There was a problem hiding this comment.
I would expect pyproject.toml to be updated in this PR as well
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Okay, maybe I misunderstood this PR. it doesn't seem to bump any dependencies but rather just updates the lock file to the most recent transient dependencies.
Still, the readme change is wrong.
Moreover the description says that auto-merge is disabled by config. I thought that it was enabled before renovate was merged.
@harshil21 could you please check these two things out and see if any config setting needs tweaking?
README.rst
Outdated
| * ``pip install "python-telegram-bot[webhooks]"`` installs the `tornado~=6.4 <https://www.tornadoweb.org/en/stable/>`_ library. Use this, if you want to use ``telegram.ext.Updater.start_webhook``/``telegram.ext.Application.run_webhook``. | ||
| * ``pip install "python-telegram-bot[callback-data]"`` installs the `cachetools>=5.3.3,<6.3.0 <https://cachetools.readthedocs.io/en/latest/>`_ library. Use this, if you want to use `arbitrary callback_data <https://github.com/python-telegram-bot/python-telegram-bot/wiki/Arbitrary-callback_data>`_. | ||
| * ``pip install "python-telegram-bot[job-queue]"`` installs the `APScheduler>=3.10.4,<3.12.0 <https://apscheduler.readthedocs.io/en/3.x/>`_ library. Use this, if you want to use the ``telegram.ext.JobQueue``. | ||
| * ``pip install "python-telegram-bot[job-queue]"`` installs the `APScheduler>=3.11.0,<3.12.0 <https://apscheduler.readthedocs.io/en/3.x/>`_ library. Use this, if you want to use the ``telegram.ext.JobQueue``. |
There was a problem hiding this comment.
| * ``pip install "python-telegram-bot[job-queue]"`` installs the `APScheduler>=3.11.0,<3.12.0 <https://apscheduler.readthedocs.io/en/3.x/>`_ library. Use this, if you want to use the ``telegram.ext.JobQueue``. | |
| * ``pip install "python-telegram-bot[job-queue]"`` installs the `APScheduler>=3.10.4,<3.12.0 <https://apscheduler.readthedocs.io/en/3.x/>`_ library. Use this, if you want to use the ``telegram.ext.JobQueue``. |
This should stay as before b/c that's what we specified in pyproject.toml and we want to bump the lower bound only if strictly necessary
| @@ -0,0 +1,5 @@ | |||
| other = "Lock file maintenance" | |||
There was a problem hiding this comment.
| other = "Lock file maintenance" | |
| internal = "Lock file maintenance" |
There was a problem hiding this comment.
what label will chango automatically recognize so all dependencies updates are "internal"?
There was a problem hiding this comment.
The mapping is currently defined here: https://github.com/python-telegram-bot/python-telegram-bot/blob/master/changes/config.py#L50
We can ofc add new labels + mapping. We can also customize the implementation even further to also depend on the author or some keyword - we can use anything from github event triggering chango. note that user-facing dependencies should be dependencies rather than internal :)
7de1f12 to
a93b4e4
Compare
84ad5bc to
6d60c11
Compare
Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - Only on Monday and Thursday ( * * * * 1,4 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.