It looks okay to me, did you do a manual test to see if it works for you?

BTW, you also have to edit the requirements accordingly (at least for travis) to prevent this error:

/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/urllib3/contrib/socks.py:37: DependencyWarning: SOCKS support in urllib3 requires the installation of optional dependencies: specifically, PySocks.  For more information, see https://urllib3.readthedocs.io/en/latest/contrib.html#socks-proxies```

@jh0ker Get it. Thanks for your tips.

@jh0ker I did a manual test, and it works well.

@jh0ker Any idea on this issue?

@daimajia that is expected behavior, no need for your to worry

BTW. This issue

It looks all right for this PR. 😃

It would be preferred to list the dependency as an extra dependency, similar to ujson. You'd have to put it in setup.py. To prevent import errors on systems where it is not installed, I recommend you move the import into the if that starts in line 97 of request.py

Good suggestion. I'll finish it ASAP.

@jh0ker Remove the PySocks dependency from requirements.txt, right? I'm not sure.

@jh0ker How about now?

@daimajia yes, please

@jh0ker Done, please check it.

@daimajia Thank you for your good work. That's something we'd really like.

1. I performed a very minimal test for your PR with ssh socks5 proxy and it works for me 👍
2. There are two minor things I would like to fix before I merge (and already have the commits ready) but I can't push to your repo/branch (and save the ping pong of asking you to do them). Can you allow the maintainers to push? See: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

right? @tsnoam

@daimajia
yes, it is good. must have been my fault earlier. anyway i pushed my small changes and after Travis will finish unitests, I believe we'll be able to merge.

@tsnoam Thanks. ❤️

@daimajia
sorry for the delay. the failure in CI is irrelevant to your changes, so I'm merging the PR.
Thanks for the good work.
BTW, I see that you haven't added yourself to AUTHORS.rst. If you'd like being mentioned there, feel free to send a second PR.

@tsnoam Thanks, I'm pretty willing to add myself to the contributors list, I'm proud of contributing to this lib. 😊