Skip to content

feat(elasticsearch): make service as an index#136

Merged
StewartJingga merged 1 commit intomainfrom
es-service-index
May 31, 2022
Merged

feat(elasticsearch): make service as an index#136
StewartJingga merged 1 commit intomainfrom
es-service-index

Conversation

@mabdh
Copy link
Member

@mabdh mabdh commented May 25, 2022

No description provided.

@mabdh mabdh linked an issue May 25, 2022 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2383502315

  • 24 of 29 (82.76%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 81.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/elasticsearch/discovery_repository.go 13 18 72.22%
Files with Coverage Reduction New Missed Lines %
internal/store/elasticsearch/discovery_repository.go 1 74.75%
Totals Coverage Status
Change from base Build 2375318138: 0.2%
Covered Lines: 4500
Relevant Lines: 5540

💛 - Coveralls

@mabdh mabdh marked this pull request as ready for review May 25, 2022 21:39
@mabdh mabdh requested a review from StewartJingga May 25, 2022 21:39
@StewartJingga StewartJingga self-requested a review May 31, 2022 03:24
@StewartJingga StewartJingga merged commit 79ca78b into main May 31, 2022
@StewartJingga StewartJingga deleted the es-service-index branch May 31, 2022 03:24
@mabdh mabdh added the enhancement New feature or request label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

avoid conflicting data type in properties attributes field

3 participants