feat(compass): add filter to get all types and move gettypes to postgres#146
Merged
feat(compass): add filter to get all types and move gettypes to postgres#146
Conversation
Pull Request Test Coverage Report for Build 2473444980
💛 - Coveralls |
Contributor
StewartJingga
left a comment
There was a problem hiding this comment.
If count is 0, the field is not being sent. It is fine for grpc calls, but for HTTP(json) calls, the response will be not as informative.
One approach we can use is to tweak our grpc json marshaller to not omit empty here.
example
gwmux := runtime.NewServeMux(
runtime.WithMarshalerOption(runtime.MIMEWildcard, &runtime.JSONPb{
MarshalOptions: protojson.MarshalOptions{
UseProtoNames: true,
EmitUnpopulated: true,
},
}),
)
wdyt @mabdh ?
Member
Author
|
@StewartJingga yes that should be fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.