Skip to content

refactor: stop usage of deprecated fields in LineageNode#178

Merged
sudo-suhas merged 1 commit intomainfrom
deprecate-lineage-node
Oct 27, 2022
Merged

refactor: stop usage of deprecated fields in LineageNode#178
sudo-suhas merged 1 commit intomainfrom
deprecate-lineage-node

Conversation

@sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Oct 12, 2022 •
edited
Loading

  • Stop usage of v1beta1.LineageNode.{type, service}. The URN is now sufficient to uniquely identify the node.
  • Modify interfaces and service to stop usage of core/asset.LineageNode, just use the URN.
    • core/asset.Service struct.
    • core/asset/LineageRepository interface.
  • Remove the type core/asset.LineageEdge.

BREAKING CHANGES:

  • Types modified - core/asset.Service, core/asset/LineageRepository.
  • Type removed - core/asset.LineageEdge.

@coveralls
Copy link

coveralls commented Oct 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3334483510

  • 35 of 35 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 86.085%
Totals Coverage Status
Change from base Build 3334473100: -0.03%
Covered Lines: 4875
Relevant Lines: 5663
💛 - Coveralls

@sudo-suhas sudo-suhas force-pushed the deprecate-lineage-node branch from c1c5e6f to 5b7620b Compare October 14, 2022 08:17
@sudo-suhas sudo-suhas mentioned this pull request Oct 14, 2022
Merged
@sudo-suhas sudo-suhas force-pushed the deprecate-lineage-node branch from 5b7620b to a60cbb8 Compare October 20, 2022 07:35
@sudo-suhas sudo-suhas marked this pull request as ready for review October 20, 2022 07:35
@StewartJingga
Copy link
Contributor

StewartJingga commented Oct 27, 2022

Nice @sudo-suhas!
Totally forgot that we now can do this

@StewartJingga
Copy link
Contributor

StewartJingga commented Oct 27, 2022 •
edited
Loading

Also CMIIW, this will require changes. on meteor's compass sink right? @sudo-suhas

Edit: Just tested this and it works fine, it seems like we still keep the API contract and just changing the internal APIs 👌

@sudo-suhas
refactor: stop usage of deprecated fields in LineageNode
d63219e 
- Stop usage of v1beta1.LineageNode.{type, service}. The URN is now
  sufficient to uniquely identify the node.
- Modify interfaces and service to stop usage of core/asset.LineageNode,
  just use the URN.
  - core/asset.Service struct.
  - core/asset/LineageRepository interface.
- Remove the type core/asset.LineageEdge.

BREAKING CHANGES:
- Types modified - core/asset.Service, core/asset/LineageRepository.
- Type removed - core/asset.LineageEdge.
@sudo-suhas sudo-suhas force-pushed the deprecate-lineage-node branch from a60cbb8 to d63219e Compare October 27, 2022 04:23
@sudo-suhas sudo-suhas merged commit 414593a into main Oct 27, 2022
@sudo-suhas sudo-suhas deleted the deprecate-lineage-node branch October 27, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sudo-suhas @coveralls @StewartJingga