Skip to content

feat: include latest probe in lineage response#180

Merged
sudo-suhas merged 1 commit intomainfrom
lineage-with-latest-probe
Oct 28, 2022
Merged

feat: include latest probe in lineage response#180
sudo-suhas merged 1 commit intomainfrom
lineage-with-latest-probe

Conversation

@sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Oct 14, 2022 •
edited
Loading

  • Return node attributes in Lineage response for GetGraph call. Node
    attributes include latest probe for asset nodes in the Graph. This
    enables showing live lineage.
  • Use context for gRPC dial and compass service handler in server.
  • Add support for fetching probes with filters from asset repository.
    Supported filters:
    • AssetURNs - zero or more asset URNs.
    • MaxRows - Number of rows for each Asset URN ordered by latest first.
    • OlderThan,NewerThan - Data range.
  • Fix some lint errors.

Done: Should be merged after #178 (would be rebased on main)

@sudo-suhas sudo-suhas marked this pull request as draft October 14, 2022 08:19
@coveralls
Copy link

coveralls commented Oct 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3334522429

  • 95 of 103 (92.23%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 86.176%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/server/v1beta1/lineage.go 19 23 82.61%
internal/store/postgres/asset_repository.go 31 35 88.57%
Totals Coverage Status
Change from base Build 3334502082: 0.09%
Covered Lines: 4962
Relevant Lines: 5758
💛 - Coveralls

@sudo-suhas sudo-suhas force-pushed the lineage-with-latest-probe branch from c1c5e6f to aced84f Compare October 20, 2022 07:38
@sudo-suhas
feat: include latest probe in lineage response
a2e6acf 
- Return node attributes in Lineage response for GetGraph call. Node
  attributes include latest probe for asset nodes in the Graph. This
  enables showing live lineage.
- Use context for gRPC dial and compass service handler in server.
- Add support for fetching probes with filters from asset repository.
  Supported filters:
  - AssetURNs - zero or more asset URNs.
  - MaxRows - Number of rows for each Asset URN ordered by latest first.
  - OlderThan,NewerThan - Data range.
  - Fix some lint errors
@sudo-suhas sudo-suhas force-pushed the lineage-with-latest-probe branch from aced84f to a2e6acf Compare October 27, 2022 04:33
@sudo-suhas sudo-suhas marked this pull request as ready for review October 27, 2022 04:34
@StewartJingga StewartJingga self-requested a review October 27, 2022 10:12
@StewartJingga
Copy link
Contributor

StewartJingga commented Oct 27, 2022

LGTM, but found an issue that may or may not be solved in this PR
#182

It is out of scope for sure, but can this be easily solved in this PR?
@sudo-suhas

@sudo-suhas
Copy link
Contributor Author

sudo-suhas commented Oct 27, 2022

Created a different PR to fix that issue - #183

This way git history is cleaner and we are not including unrelated change in this PR.

StewartJingga
StewartJingga approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudo-suhas sudo-suhas merged commit 1c6d3ac into main Oct 28, 2022
@sudo-suhas sudo-suhas deleted the lineage-with-latest-probe branch October 28, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sudo-suhas @coveralls @StewartJingga