Conversation
Contributor
sudo-suhas
commented
Feb 21, 2023
- Add column to assets table for URL.
- Store the asset's URL field in DB as part of insert/upsert.
- Retrieve the asset's URL field from DB for fetch APIs.
- Refactor UPDATE statement to use squirrel for easier maintenance.
- Add column to assets table for URL. - Store the asset's URL field in DB as part of insert/upsert. - Retrieve the asset's URL field from DB for fetch APIs. - Refactor UPDATE statement to use squirrel for easier maintenance.
Pull Request Test Coverage Report for Build 4232473912
💛 - Coveralls |
haveiss
approved these changes
Feb 22, 2023
| a.service as service, | ||
| a.description as description, | ||
| a.data as data, | ||
| COALESCE(a.url, '') as url, |
There was a problem hiding this comment.
how this compared to set url default to '' when altering table?
Contributor
Author
There was a problem hiding this comment.
Altering a table with default value used to take a lock for updating all rows (which would block reads and writes). This looks to have been fixed in PG 11 but I wasn't aware of that while making these changes.
Pull Request Test Coverage Report for Build 4232473912Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 4232473912Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.