Skip to content

fix: fix Docker dev build for admin app#1360

Merged
rohilsurana merged 2 commits intomainfrom
fix/context-path
Jan 30, 2026
Merged

fix: fix Docker dev build for admin app#1360
rohilsurana merged 2 commits intomainfrom
fix/context-path

Conversation

@paanSinghCoder
Copy link
Contributor

@paanSinghCoder paanSinghCoder commented Jan 30, 2026

Summary

  • Dockerfile.dev: Use node:20-alpine (match engines), install make, git, and pnpm@9.3.0 in the admin-builder stage.
  • web/apps/admin/Makefile: Use pnpm install only; drop --legacy-peer-deps -f (npm-only flags).

Test Plan

  • Manual testing completed by running docker compose build --no-cache
  • Build and type checking passes

@vercel
Copy link

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jan 30, 2026 9:04am

@coveralls
Copy link

coveralls commented Jan 30, 2026

Pull Request Test Coverage Report for Build 21510285514

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.882%

Totals Coverage Status
Change from base Build 21478939325: 0.0%
Covered Lines: 15887
Relevant Lines: 41938

💛 - Coveralls

@paanSinghCoder paanSinghCoder changed the title chore: update Dockerfile.dev to include git and pnpm installation fix: fix Docker dev build for admin app Jan 30, 2026
@rohilsurana rohilsurana merged commit ce94379 into main Jan 30, 2026
7 checks passed
@rohilsurana rohilsurana deleted the fix/context-path branch January 30, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants