feat(preference): add SelectValidator for select/combobox inputs#1364
Merged
whoAbhishekSah merged 1 commit intomainfrom Feb 3, 2026
Merged
feat(preference): add SelectValidator for select/combobox inputs#1364whoAbhishekSah merged 1 commit intomainfrom
whoAbhishekSah merged 1 commit intomainfrom
Conversation
Add SelectValidator that validates preference values against allowed options defined in InputHints (comma-separated). This enables proper validation for select and combobox trait input types. - Add SelectValidator to validator.go - Update GetValidator() to use SelectValidator for select/combobox - Add comprehensive unit tests for all validators Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 21580803602Details
💛 - Coveralls |
rohilsurana
approved these changes
Feb 3, 2026
whoAbhishekSah
commented
Feb 3, 2026
Member
Author
|
#1347 linked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SelectValidatorthat validates preference values against allowed options inInputHintsGetValidator()to useSelectValidatorforselectandcomboboxinput typesDetails
SelectValidatorparses comma-separated values fromInputHintsfieldInputHintsconfigured, accepts any non-empty valuemultiselectintentionally excluded (needs different parsing for multi-value input)Test Plan
go test ./core/preference/... -v(27 tests)go build ./...🤖 Generated with Claude Code