Skip to content

feat: update slack notification by adding block functionality to template#370

Merged
bsushmith merged 10 commits intomainfrom
slack_notification_enhancement
Mar 6, 2023
Merged

feat: update slack notification by adding block functionality to template#370
bsushmith merged 10 commits intomainfrom
slack_notification_enhancement

Conversation

@utsav14nov
Copy link
Contributor

@utsav14nov utsav14nov commented Feb 24, 2023

feat: update slack notification by adding block functionality to template

@coveralls
Copy link

coveralls commented Feb 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4339427071

  • 33 of 51 (64.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 74.962%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/notifiers/slack/client.go 26 44 59.09%
Totals Coverage Status
Change from base Build 4249606976: -0.1%
Covered Lines: 7799
Relevant Lines: 10404
💛 - Coveralls

@utsav14nov utsav14nov linked an issue Feb 24, 2023 that may be closed by this pull request
Guardian Approval through Slack #363
Closed
haveiss
haveiss reviewed Feb 24, 2023
View reviewed changes
bsushmith
bsushmith reviewed Feb 24, 2023
View reviewed changes
bsushmith
bsushmith reviewed Feb 24, 2023
View reviewed changes
bsushmith
bsushmith reviewed Feb 27, 2023
View reviewed changes
bsushmith
bsushmith reviewed Feb 27, 2023
View reviewed changes
bsushmith
bsushmith reviewed Feb 27, 2023
View reviewed changes
rahmatrhd
rahmatrhd reviewed Feb 27, 2023
View reviewed changes
@utsav14nov
Copy link
Contributor Author

utsav14nov commented Feb 27, 2023

@rahmatrhd As checked in terraform, we are be able to read full content from a json file as string and use it as variable in config which makes easily maintainable and structured code in production.
And as you suggested we can add the default config as separate json in guardian and read it programmatically through code.
What say? @bsushmith @haveiss

@bsushmith
Copy link
Member

bsushmith commented Feb 27, 2023

@utsav14nov Yes. That is fine from a deployment using terraform. But for other kinds of deployment, @rahmatrhd's comment still stands true.
But then again, it should be fine, as long as the user is able to maintain these big strings on their end irrespective of deployment method.

@singhvikash11
Copy link
Member

singhvikash11 commented Feb 27, 2023 •
edited
Loading

@rahmatrhd please have a look of pr #330

bsushmith
bsushmith reviewed Mar 1, 2023
View reviewed changes
bsushmith
bsushmith reviewed Mar 1, 2023
View reviewed changes
@utsav14nov utsav14nov requested a review from haveiss March 1, 2023 11:04
haveiss
haveiss reviewed Mar 3, 2023
View reviewed changes
rahmatrhd
rahmatrhd reviewed Mar 5, 2023
View reviewed changes
@utsav14nov utsav14nov requested review from haveiss and rahmatrhd March 6, 2023 02:57
haveiss
haveiss reviewed Mar 6, 2023
View reviewed changes
@bsushmith bsushmith merged commit aa29ea8 into main Mar 6, 2023
@bsushmith bsushmith deleted the slack_notification_enhancement branch March 6, 2023 06:15
@bsushmith bsushmith mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haveiss haveiss haveiss approved these changes

@bsushmith bsushmith bsushmith approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd rahmatrhd is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Guardian Approval through Slack

6 participants

@utsav14nov @coveralls @bsushmith @singhvikash11 @haveiss @rahmatrhd