Skip to content

feat: add application_yaml extractor#427

Merged
ravisuhag merged 1 commit intomainfrom
service_yaml-extractor
Nov 16, 2022
Merged

feat: add application_yaml extractor#427
ravisuhag merged 1 commit intomainfrom
service_yaml-extractor

Conversation

@sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Oct 29, 2022 •
edited
Loading

  • Add application_yaml extractor for reading the given YAML file and emitting an Asset of type service.
  • Fix relative link to contributing guide in plugin READMEs.
  • Remove unused code in utils/config.go
  • Move private helper functions in caramlstore extractor to plugin pkg for
    • parsing Kafka scope from bootstrap servers
    • constructing URN from BigQuery table's fully qualified name.

[DONE] Needs raystack/proton#214 to be merged first (update PROTON_COMMIT in the Makefile after that)

@sudo-suhas sudo-suhas force-pushed the service_yaml-extractor branch from 04f8605 to bc44298 Compare October 29, 2022 04:31
StewartJingga
StewartJingga reviewed Nov 4, 2022
View reviewed changes
ravisuhag
ravisuhag reviewed Nov 4, 2022
View reviewed changes
@sudo-suhas sudo-suhas force-pushed the service_yaml-extractor branch from bc44298 to 7010a36 Compare November 4, 2022 04:51
@sudo-suhas sudo-suhas mentioned this pull request Nov 4, 2022
Merged
@sudo-suhas sudo-suhas force-pushed the service_yaml-extractor branch from 7010a36 to 7566e48 Compare November 4, 2022 05:36
@sudo-suhas sudo-suhas changed the title feat: add service_yaml extractor feat: add application_yaml extractor Nov 4, 2022
@sudo-suhas sudo-suhas force-pushed the service_yaml-extractor branch from 7566e48 to 93aa0cc Compare November 4, 2022 06:10
sudo-suhas
sudo-suhas commented Nov 4, 2022
View reviewed changes
@sudo-suhas sudo-suhas force-pushed the service_yaml-extractor branch from 93aa0cc to 5dd5081 Compare November 4, 2022 11:21
StewartJingga
StewartJingga approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudo-suhas sudo-suhas force-pushed the service_yaml-extractor branch 2 times, most recently from ade27ac to 618d504 Compare November 11, 2022 08:58
@sudo-suhas
Copy link
Contributor Author

sudo-suhas commented Nov 11, 2022

@StewartJingga do you want to take a final look or shall I go ahead and merge this in?

@sudo-suhas
feat: add application_yaml extractor
94ce1b7 
- Add application_yaml extractor for reading the given YAML file and
  emitting an Asset of type service.
- Fix relative link to contributing guide in plugin READMEs.
- Remove unused code in utils/config.go
- Move private helper functions in caramlstore extractor to plugin pkg
  for
  - parsing Kafka scope from bootstrap servers
  - constructing URN from BigQuery table's fully qualified name.
@sudo-suhas sudo-suhas force-pushed the service_yaml-extractor branch from 618d504 to 94ce1b7 Compare November 16, 2022 05:53
@ravisuhag ravisuhag merged commit d3cde4e into main Nov 16, 2022
@ravisuhag ravisuhag deleted the service_yaml-extractor branch November 16, 2022 07:00
@sudo-suhas sudo-suhas mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravisuhag ravisuhag ravisuhag left review comments

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sudo-suhas @ravisuhag @StewartJingga