feat!: support serving multiple servers on separate ports#63
Merged
StewartJingga merged 1 commit intomainfrom Nov 30, 2022
Merged
feat!: support serving multiple servers on separate ports#63StewartJingga merged 1 commit intomainfrom
StewartJingga merged 1 commit intomainfrom
Conversation
a346718 to
00f9941
Compare
spy16
approved these changes
Nov 29, 2022
Graceful shutdown of gRPC server is not possible with multiplexing of the HTTP and gRPC server on a single port. So make breaking changes to the mux pkg to instead accept and orchestrate multiple serve targets.
00f9941 to
0a5564a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graceful shutdown of gRPC server is not possible with multiplexing of the HTTP and gRPC server on a single port. So make breaking changes to the mux pkg to instead accept and orchestrate multiple serve targets.
Related to raystack/compass#164.