translated warnings/invalid-aria-prop#123
Merged
Fcmam5 merged 3 commits intoreactjs:masterfrom Jul 2, 2019
Merged
Conversation
mohshbool
commented
Jun 29, 2019
|
Deploy preview for ar-reactjs ready! Built with commit 175aa2e |
Fcmam5
reviewed
Jul 1, 2019
Collaborator
Fcmam5
left a comment
There was a problem hiding this comment.
All my respect Mohammed! I really love what you're doing, especially when it comes to "make tashkeel" to the hard words.
I had some micro-suggestions 🔬 to fix when it's possible :)
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Member
|
Hi @Fcmam5, please review this PR and merge it after approving it.
Thanks. |
mohshbool
commented
Jul 2, 2019
Member
Author
|
@Fcmam5 I think it's done now 😄 |
Fcmam5
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
done translating warnings/invalid-aria-prop.*