[Done] Translation of videos.md ..#156
Merged
3imed-jaberi merged 6 commits intoreactjs:masterfrom Aug 4, 2019
Merged
Conversation
|
Deploy preview for ar-reactjs ready! Built with commit 481094f |
Collaborator
I suggest keeping them without translation, the description is enough |
Fcmam5
requested changes
Aug 4, 2019
Collaborator
Fcmam5
left a comment
There was a problem hiding this comment.
Hi Imed thanks again for your efforts, I left below some comments and suggestions. Also please uncomment and translate the video lengths like in the line 31.
Also, what do you think of translating titles that doesn't have the conference name or something, like those who have simple sentences like React and Flux: Building Applications with a Unidirectional Data Flow, Introduction to React ?
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Fcmam5
approved these changes
Aug 4, 2019
mohshbool
approved these changes
Aug 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if should translate the titles or leave them like conf section.