Skip to content

Done Translating-hooks-faq.md#69

Merged
iRayan7 merged 6 commits intoreactjs:masterfrom
splimter:Translating-hooks-faq.md
Aug 8, 2019
Merged

Done Translating-hooks-faq.md#69
iRayan7 merged 6 commits intoreactjs:masterfrom
splimter:Translating-hooks-faq.md

Conversation

@splimter
Copy link
Member

@splimter splimter commented Apr 3, 2019

No description provided.

@netlify
Copy link

netlify bot commented Apr 3, 2019 •
edited
Loading

Deploy preview for ar-reactjs ready!

Built with commit 08b13d5

https://deploy-preview-69--ar-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request Apr 6, 2019
Closed
@asantarissy asantarissy requested a review from iRayan7 April 8, 2019 15:15
@iRayan7 iRayan7 self-requested a review April 20, 2019 08:15
iRayan7
iRayan7 requested changes Apr 20, 2019
View reviewed changes
Copy link
Member

@iRayan7 iRayan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure all questions are been translated.
Hsoub's version of this page doesn't translate all questions.
From Classes to Hooks and Performance Optimizations have few questions still untranslated.
Thanks.

@iRayan7 iRayan7 self-requested a review May 24, 2019 20:17
iRayan7
iRayan7 requested changes May 24, 2019
View reviewed changes
Copy link
Member

@iRayan7 iRayan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance Optimizations

@iRayan7 iRayan7 added the update needed This PR needs update since last commit label Jun 25, 2019
@3imed-jaberi 3imed-jaberi requested review from Fcmam5 and mohshbool July 30, 2019 09:07
@3imed-jaberi 3imed-jaberi added in-review and removed changes-requested update needed This PR needs update since last commit work-in-progress labels Jul 30, 2019
Fcmam5
Fcmam5 requested changes Jul 30, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really had a good time reading your translation! Thank you Soheyb.
I have some suggestions and some corrections to make, also:

  • Please double check the code examples, some comments are not translated yet.
  • Fix some formatting issues like some ** ** are not rendered correctly, please check it when you run the documentation locally or on your deployed PR
  • Some chunks appeared to be added and not modified (like in line 370 and 450) did you have the last changes from the upstream branch before submitting this PR?

@splimter
Copy link
Member Author

splimter commented Jul 31, 2019

Going to Resolve Problems now !!

@splimter splimter force-pushed the Translating-hooks-faq.md branch from f32b7b0 to 2ed236a Compare August 1, 2019 12:26
@mohshbool mohshbool removed their request for review August 6, 2019 16:23
@3imed-jaberi
Copy link
Member

3imed-jaberi commented Aug 7, 2019

@splimter, please bro discuss with reviewers don't put the conversation in resolve mode ..

@3imed-jaberi 3imed-jaberi added update needed This PR needs update since last commit work-in-progress and removed in-review labels Aug 7, 2019
@splimter
Copy link
Member Author

splimter commented Aug 8, 2019

@splimter, please bro discuss with reviewers don't put the conversation in resolve mode ..

i will keep it in mind next time ...
... is there any other issue ?

@iRayan7 iRayan7 added approved and removed update needed This PR needs update since last commit work-in-progress labels Aug 8, 2019
@iRayan7 iRayan7 closed this Aug 8, 2019
@iRayan7 iRayan7 reopened this Aug 8, 2019
@iRayan7 iRayan7 merged commit 4034f4e into reactjs:master Aug 8, 2019
@iRayan7
Copy link
Member

iRayan7 commented Aug 8, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fcmam5 Fcmam5 Fcmam5 requested changes

@iRayan7 iRayan7 iRayan7 approved these changes

Assignees

@iRayan7 iRayan7

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@splimter @3imed-jaberi @iRayan7 @Fcmam5 @asantarissy