Translate render and commit page#12
Merged
moshfiqrony merged 5 commits intoreactjs:mainfrom May 2, 2023
Merged
Conversation
Collaborator
|
Great work @MahdiMurshed one of the maintainers will get this reviewed as soon as possible (I can if no one gets to it first) and we can get this merged soon! 💯 🏆 🥇 |
shakib609
previously requested changes
May 2, 2023
Member
shakib609
left a comment
There was a problem hiding this comment.
Found some minor issues @MahdiMurshed .
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
moshfiqrony
approved these changes
May 2, 2023
Collaborator
There was a problem hiding this comment.
LGTM. Great effort @MahdiMurshed Let's wait for one more contributor's approval to merge it.
nomandhoni-cs
approved these changes
May 2, 2023
Contributor
Author
okay bhai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.