Complete the Translation of PR #103 'Synchronizing with effects (60%)'#160
Merged
moshfiqrony merged 72 commits intoreactjs:mainfrom Jun 29, 2025
Merged
Complete the Translation of PR #103 'Synchronizing with effects (60%)'#160moshfiqrony merged 72 commits intoreactjs:mainfrom
moshfiqrony merged 72 commits intoreactjs:mainfrom
Conversation
Collaborator
Author
|
@nafistiham @moshfiqrony রিভিউ এর অপেক্ষায়। |
Collaborator
|
I'll review it as soon as possible. Thanks for your hard and honest work! |
nafistiham
reviewed
Oct 26, 2024
nafistiham
reviewed
Oct 26, 2024
nafistiham
reviewed
Oct 26, 2024
nafistiham
reviewed
Oct 26, 2024
nafistiham
requested changes
Oct 26, 2024
Collaborator
nafistiham
left a comment
There was a problem hiding this comment.
অনেক ধন্যবাদ বিশাল একটা পেইজে কাজ করবার জন্য।
কিছু কমেন্ট করেছি। কিছু বিষয় পরিবর্তনের অনুরোধ করব।
- কমিটের সংখ্যা অত্যধিক এবং অপ্রয়োজনীয় মনে হয়েছে। একটা দুইটা শব্দ বদলিয়ে কমিট করা হয়েছে। অনুরোধ করব কমিটগুলোকে স্কোয়াশ করে ২০-৩০ টা কমিটে নিয়ে যেতে।
- React সহ অনেক টেকনিকাল শব্দ আমরা ইংরেজিতেই রাখার চেষ্টা করছি। এ বিষয়ে আরেকবার রিভাইজ করলে ভাল হয়।
- কোডের মধ্যকার কিছু না বদলাই। সি আই সি ডি পাইপলাইনে ঝামেলা করে মাঝে মাঝে।
এ বিষয়গুলো মাথায় রেখে আরেকবার ঠিক করেন। এর পর আবার রিভিউ করব।
- Fix spelling and typos throughout the document - Improve translations - Fix line breaks
Co-authored-by: Nafis Tiham <nafistiham@gmail.com>
Co-authored-by: Nafis Tiham <nafistiham@gmail.com> Adjust translation in synchronizing-with-effects.md Revert React keyword back to English
1cb600e to
226208d
Compare
Collaborator
Author
@nafistiham রিভিউর জন্য ধন্যবাদ।
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues and completes the work started in PR #103 by @AFM-Taha.
Once reviewed and approved, this PR can replace #103.