Skip to content

Translate Lists and Keys#14

Merged
resir014 merged 9 commits intoreactjs:masterfrom
aisy:aisy-branch
Dec 25, 2019
Merged

Translate Lists and Keys#14
resir014 merged 9 commits intoreactjs:masterfrom
aisy:aisy-branch

Conversation

@aisy
Copy link
Contributor

@aisy aisy commented Feb 11, 2019

Hi, finally i can manage this section..
please kindly check the content

@aisy aisy changed the title menerjemahkan konten list & key translate List & Keys Feb 11, 2019
mazipan
mazipan reviewed Feb 11, 2019
View reviewed changes
mazipan
mazipan reviewed Feb 11, 2019
View reviewed changes
@mazipan
Copy link
Collaborator

mazipan commented Feb 11, 2019

Please read #2

@tesseralis tesseralis mentioned this pull request Feb 11, 2019
Closed
96 tasks
mazipan
mazipan requested changes Feb 11, 2019
View reviewed changes
@aisy
Copy link
Contributor Author

aisy commented Feb 12, 2019

Sure @mazipan..
i'll update soon and let everyone knows...
thank you

regalius
regalius requested changes Feb 12, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to adjust several common terms & italicize several loanwords mas @aisy 🎉

@aisy
Copy link
Contributor Author

aisy commented Feb 12, 2019

Sure @regalius..
little busy right now.. maybe ill update tonight or tomorrow

regalius
regalius requested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found several other words that need adjustment mas 😄

regalius
regalius reviewed Feb 13, 2019
View reviewed changes
gedeagas
gedeagas requested changes Feb 14, 2019
View reviewed changes
Copy link
Member

@gedeagas gedeagas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ada minor komen mas @aisy, penggunaan kata anda sebaga kata sapaan sebaiknya mengunakan huruf awalan besar (eg: Anda).

Yang aku komentari cuma sebagian contoh mas, coba nanti di lihat lagi di file nya.

mazipan
mazipan requested changes Feb 15, 2019
View reviewed changes
arfianadam
arfianadam requested changes Feb 17, 2019
View reviewed changes
@regalius
Copy link
Member

regalius commented Mar 3, 2019 •
edited
Loading

Hi mas @aisy , any update about this PR? Also I've noticed there's conflicting file with the upstream, kindly please resolve the conflict and add the new translation 😄

@aisy
Copy link
Contributor Author

aisy commented Mar 5, 2019

sorry i'm kinda busy with my work..
i'm back again and ill update at night @regalius

@netlify
Copy link

netlify bot commented Mar 5, 2019 •
edited
Loading

Deploy preview for idreactjs ready!

Built with commit 30cec9c

https://deploy-preview-14--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 5, 2019 •
edited
Loading

Deploy preview for id-reactjs ready!

Built with commit 30cec9c

https://deploy-preview-14--id-reactjs.netlify.com

@regalius
Copy link
Member

regalius commented Mar 9, 2019

Hi mas @aisy , noticed there's several requested changes that hadn't been resolved yet also the conflict with upstream, do you think you can still do this or need others to help? 😄

@gedeagas gedeagas requested review from arfianadam and gedeagas April 12, 2019 12:30
@grikomsn grikomsn changed the title translate List & Keys Translate Lists and Keys Jul 7, 2019
@resir014 resir014 merged commit 03cfe4b into reactjs:master Dec 25, 2019
resir014 added a commit that referenced this pull request Dec 25, 2019
@resir014
perulangan -> mengulang-ulang
daee33c 
Ref: #14 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@regalius regalius regalius requested changes

@mazipan mazipan mazipan requested changes

@resir014 resir014 resir014 approved these changes

@arfianadam arfianadam Awaiting requested review from arfianadam

@gedeagas gedeagas Awaiting requested review from gedeagas

+1 more reviewer

@itsnotrisky itsnotrisky itsnotrisky left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aisy @mazipan @regalius @itsnotrisky @resir014 @gedeagas @arfianadam