New Indonesian translation: `importing and exporting components` by aroyan · Pull Request #345 · reactjs/id.react.dev

aroyan · 2023-04-26T14:54:42Z

Translation for Importing and Exporting Components

Related with:

New Indonesian Translation Progress #330

Closes #417

github-actions · 2023-04-26T14:56:43Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

src/content/learn/importing-and-exporting-components.md

Co-authored-by: RiN <hi@rin.rocks>

github-actions · 2023-04-26T22:15:20Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2023-04-26T22:29:55Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

aroyan · 2023-04-26T22:32:28Z

Thanks for the suggestion @r17x. I have a question, what about usage of import/eksport? Should I use it with t or not? I've seen some translation is using impor/ekspor but the glossary is using it with t, so I'm not so sure which one to use

src/content/learn/importing-and-exporting-components.md

- Use `impor/ekspor` instead of `import/eksport` - Use `Ilmuwan` the standard one instead of `Ilmuan` - Fix grammatical error Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>

github-actions · 2023-04-27T01:00:22Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

- fix some typo

github-actions · 2023-04-27T01:36:13Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2023-04-27T02:04:10Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

src/content/learn/importing-and-exporting-components.md

mhaidarhanif

A minor suggestion.

src/content/learn/importing-and-exporting-components.md

Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>

github-actions · 2023-04-28T01:16:02Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2023-04-28T01:17:23Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif · 2023-04-28T03:05:09Z

@aroyan I have a question, what about usage of import/eksport? Should I use it with t or not? I've seen some translation is using impor/ekspor but the glossary is using it with t, so I'm not so sure which one to use

About this one (not sure if already clarified or not in this PR), we can check and discuss it here: #337 (comment)

The official pair from KBBI are impor and ekspor.

aroyan · 2023-04-28T03:20:12Z

@aroyan I have a question, what about usage of import/eksport? Should I use it with t or not? I've seen some translation is using impor/ekspor but the glossary is using it with t, so I'm not so sure which one to use

About this one (not sure if already clarified or not in this PR), we can check and discuss it here: #337 (comment)

The official pair from KBBI are impor and ekspor.

@mazipan said to use impor/ekspor, and I've updated it yesterday

mhaidarhanif · 2023-04-28T14:33:37Z

@mazipan said to use impor/ekspor, and I've updated it yesterday

Yes impor/ekspor has been confirmed.

github-actions · 2023-04-28T14:35:21Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif · 2023-04-28T14:35:22Z

Let's be ready to merge.

mhaidarhanif · 2023-04-28T14:36:44Z

@r17x your requested changes have been resolved.

All requested changes have been resolved.

Co-authored-by: RiN <hi@rin.rocks> Co-authored-by: Irfan Maulana <mazipanneh@gmail.com> Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>

feat: add translation to bahasa

b07ea4f

vercel bot deployed to Preview – id-react-dev April 26, 2023 14:55 View deployment

r17x previously requested changes Apr 26, 2023

View reviewed changes

use italic for usage of file

9279bd8

Co-authored-by: RiN <hi@rin.rocks>

vercel bot deployed to Preview – id-react-dev April 26, 2023 22:13 View deployment

use italic for non Indonesian words

8b89543

vercel bot deployed to Preview – id-react-dev April 26, 2023 22:28 View deployment

mazipan reviewed Apr 26, 2023

View reviewed changes

src/content/learn/importing-and-exporting-components.md Outdated Show resolved Hide resolved

mazipan reviewed Apr 26, 2023

View reviewed changes

Apply suggestions from code review

e05eff0

- Use `impor/ekspor` instead of `import/eksport` - Use `Ilmuwan` the standard one instead of `Ilmuan` - Fix grammatical error Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>

vercel bot deployed to Preview – id-react-dev April 27, 2023 00:59 View deployment

use impor/ekspor instead of import/eksport

9ce9643

- fix some typo

vercel bot deployed to Preview – id-react-dev April 27, 2023 01:35 View deployment

fix formatting

cbeec89

vercel bot deployed to Preview – id-react-dev April 27, 2023 02:02 View deployment

mazipan reviewed Apr 27, 2023

View reviewed changes

src/content/learn/importing-and-exporting-components.md Outdated Show resolved Hide resolved

mhaidarhanif reviewed Apr 27, 2023

View reviewed changes

src/content/learn/importing-and-exporting-components.md Outdated Show resolved Hide resolved

mhaidarhanif requested changes Apr 27, 2023

View reviewed changes

src/content/learn/importing-and-exporting-components.md Outdated Show resolved Hide resolved

Update src/content/learn/importing-and-exporting-components.md

f9c01c1

Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>

vercel bot deployed to Preview – id-react-dev April 28, 2023 01:14 View deployment

fix grammar for code example

626bc79

vercel bot deployed to Preview – id-react-dev April 28, 2023 01:16 View deployment

aroyan changed the title ~~translation for importing and exporting components~~ docs: translation for importing and exporting components Apr 28, 2023

Merge branch 'main' into docs/translation/learn

a26bb3d

vercel bot deployed to Preview – id-react-dev April 28, 2023 14:33 View deployment

mhaidarhanif approved these changes Apr 28, 2023

View reviewed changes

mhaidarhanif merged commit 4fc8bdd into reactjs:main Apr 28, 2023

mhaidarhanif changed the title ~~docs: translation for importing and exporting components~~ New Indonesian translation: importing and exporting components Apr 28, 2023

r17x added a commit that referenced this pull request May 8, 2023

New Indonesian translation: importing and exporting components (#345)

42594ed

Co-authored-by: RiN <hi@rin.rocks> Co-authored-by: Irfan Maulana <mazipanneh@gmail.com> Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>

aroyan deleted the docs/translation/learn branch August 2, 2024 12:29

Conversation

aroyan commented Apr 26, 2023 • edited by zainfathoni Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 26, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 26, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

github-actions bot commented Apr 26, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

aroyan commented Apr 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 27, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

github-actions bot commented Apr 27, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

github-actions bot commented Apr 27, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

Uh oh!

Uh oh!

mhaidarhanif left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

github-actions bot commented Apr 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

mhaidarhanif commented Apr 28, 2023

Uh oh!

aroyan commented Apr 28, 2023

Uh oh!

mhaidarhanif commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

mhaidarhanif commented Apr 28, 2023

Uh oh!

mhaidarhanif commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

aroyan commented Apr 26, 2023 •

edited by zainfathoni

Loading

mhaidarhanif commented Apr 28, 2023 •

edited

Loading