translation for scaling up with reducer and context#364
Merged
mhaidarhanif merged 11 commits intoreactjs:mainfrom May 1, 2023
R1dwanMaulana:translate-scaling-up-with-reducer-and-context
Merged
translation for scaling up with reducer and context#364mhaidarhanif merged 11 commits intoreactjs:mainfrom R1dwanMaulana:translate-scaling-up-with-reducer-and-context
mhaidarhanif merged 11 commits intoreactjs:mainfrom
R1dwanMaulana:translate-scaling-up-with-reducer-and-context
Conversation
mazipan
requested changes
Apr 28, 2023
r17x
requested changes
Apr 29, 2023
r17x
approved these changes
Apr 29, 2023
mazipan
reviewed
Apr 30, 2023
mazipan
reviewed
Apr 30, 2023
…up with reducer and context
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mhaidarhanif
approved these changes
May 1, 2023
mhaidarhanif
requested changes
May 1, 2023
Collaborator
There was a problem hiding this comment.
Suggestion. Also wait for @r17x @mazipan @resir014 @zainfathoni to give final reviews.
zainfathoni
requested changes
May 1, 2023
Collaborator
zainfathoni
left a comment
There was a problem hiding this comment.
Thanks for contributing!
I have a few minor suggestions. 😁
zainfathoni
requested changes
May 1, 2023
Collaborator
zainfathoni
left a comment
There was a problem hiding this comment.
Thanks for addressing all my suggestions!
I have one final correction. Please address it, and don't forget to update it to the latest changes in the main branch, and it should be ready to merge! 💯
zainfathoni
approved these changes
May 1, 2023
Collaborator
zainfathoni
left a comment
There was a problem hiding this comment.
LGTM 💯
Thanks for contributing and addressing all the comments! 🙏
mhaidarhanif
approved these changes
May 1, 2023
r17x
pushed a commit
that referenced
this pull request
May 8, 2023
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com> Co-authored-by: Zain Fathoni <me@zainf.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #385
translation for scaling up with reducer and context docs reference by #330