New Indonesian Translation: Sharing State Between Components by yaffalhakim1 · Pull Request #370 · reactjs/id.react.dev

yaffalhakim1 · 2023-04-28T02:44:45Z

Hi, this PR is for #330
New translation for page Sharing State Between Components

Closes #381

Co-authored-by: Resi Respati <resir014@gmail.com>

…react.dev into react-dev-tools

github-actions · 2023-04-28T02:46:36Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2023-04-28T02:56:37Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

…/yaffalhakim1/id.react.dev into sharing-state-between-components

github-actions · 2023-04-28T04:51:02Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2023-04-29T03:57:39Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

yaffalhakim1 · 2023-04-29T04:01:06Z

Hi mas @resir014 and maintainers. This pr is ready to review. You can check in this commits:

e2f46eb
5b1eb14
thank you!

resir014

First pass of code review. Here are some needed changes! @yaffalhakim1

src/content/learn/sharing-state-between-components.md

yaffalhakim1 · 2023-04-29T04:49:08Z

First pass of code review. Here are some needed changes! @yaffalhakim1

alright mas, I will commit the suggestion ASAP while waiting for other maintainers to give their reviews.

Co-authored-by: Resi Respati <resir014@gmail.com>

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

applying all suggestion from reviewers Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

yaffalhakim1 · 2023-05-01T12:32:29Z

Thanks for contributing! I have a few more suggestions here. 😁

surely, I missed a lot 😓, thank you for the review mas. ready to re-review

zainfathoni

LGTM 💯
Approved with a minor suggestion for paraphrasing. 😁

Thanks for contributing! 🙏

src/content/learn/sharing-state-between-components.md

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

there are already 3 review approvals

Co-authored-by: Resi Respati <resir014@gmail.com> Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com> Co-authored-by: Zain Fathoni <me@zainf.dev> Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

yaffalhakim1 and others added 8 commits April 26, 2023 11:55

translating react developer tools docs to bahasa indonesia

4b19fd5

Update src/content/learn/react-developer-tools.md

cabe59e

Co-authored-by: Resi Respati <resir014@gmail.com>

created changes based on review

1b4873a

Update src/content/learn/react-developer-tools.md

748522d

Co-authored-by: Resi Respati <resir014@gmail.com>

Merge branch 'react-dev-tools' of https://github.com/yaffalhakim1/id.…

35a1a3a

…react.dev into react-dev-tools

change some words according to Glosarium

b75c6f8

change title in sharing state between component

452cd88

change intro

bb4556b

vercel bot deployed to Preview – id-react-dev April 28, 2023 02:45 View deployment

yaffalhakim1 changed the title ~~Sharing state between components~~ New Indonesian Translation: Sharing State Between Components Apr 28, 2023

Merge branch 'reactjs:main' into sharing-state-between-components

ffc985a

vercel bot deployed to Preview – id-react-dev April 28, 2023 02:55 View deployment

yaffalhakim1 added 2 commits April 28, 2023 11:48

until step 3

e2f46eb

Merge branch 'sharing-state-between-components' of https://github.com…

8256aea

…/yaffalhakim1/id.react.dev into sharing-state-between-components

vercel bot deployed to Preview – id-react-dev April 28, 2023 04:49 View deployment

yaffalhakim1 mentioned this pull request Apr 28, 2023

Sharing State Between Components #381

Closed

all set, ready to review

5b1eb14

vercel bot deployed to Preview – id-react-dev April 29, 2023 03:56 View deployment

yaffalhakim1 marked this pull request as ready for review April 29, 2023 04:01

resir014 previously requested changes Apr 29, 2023

View reviewed changes

yaffalhakim1 and others added 4 commits April 29, 2023 13:00

Update src/content/learn/sharing-state-between-components.md

94c79dd

Co-authored-by: Resi Respati <resir014@gmail.com>

Update src/content/learn/sharing-state-between-components.md

b39f6c5

Co-authored-by: Resi Respati <resir014@gmail.com>

Update src/content/learn/sharing-state-between-components.md

07fed0e

Co-authored-by: Resi Respati <resir014@gmail.com>

Update src/content/learn/sharing-state-between-components.md

e437fd3

Co-authored-by: Resi Respati <resir014@gmail.com>

yaffalhakim1 and others added 3 commits May 1, 2023 18:18

Update src/content/learn/sharing-state-between-components.md

8588e35

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

Update src/content/learn/sharing-state-between-components.md

b157557

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

Update src/content/learn/sharing-state-between-components.md

7a653c1

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

vercel bot deployed to Preview – id-react-dev May 1, 2023 11:20 View deployment

yaffalhakim1 and others added 2 commits May 1, 2023 18:54

Update src/content/learn/sharing-state-between-components.md

a10230c

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

Update src/content/learn/sharing-state-between-components.md

274abfe

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

vercel bot deployed to Preview – id-react-dev May 1, 2023 11:55 View deployment

Update src/content/learn/sharing-state-between-components.md

e6545ec

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

vercel bot deployed to Preview – id-react-dev May 1, 2023 12:13 View deployment

Update src/content/learn/sharing-state-between-components.md

0a17ee6

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

vercel bot deployed to Preview – id-react-dev May 1, 2023 12:18 View deployment

Update src/content/learn/sharing-state-between-components.md

31c47ba

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

vercel bot deployed to Preview – id-react-dev May 1, 2023 12:19 View deployment

Update src/content/learn/sharing-state-between-components.md

5d3d17d

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

vercel bot deployed to Preview – id-react-dev May 1, 2023 12:26 View deployment

Apply suggestions from code review

db83f98

applying all suggestion from reviewers Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

vercel bot deployed to Preview – id-react-dev May 1, 2023 12:29 View deployment

yaffalhakim1 requested a review from zainfathoni May 1, 2023 12:34

mhaidarhanif approved these changes May 1, 2023

View reviewed changes

Merge branch 'main' into sharing-state-between-components

5a99d25

vercel bot deployed to Preview – id-react-dev May 1, 2023 14:53 View deployment

zainfathoni approved these changes May 1, 2023

View reviewed changes

src/content/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved

Update src/content/learn/sharing-state-between-components.md

faa73c3

Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>

vercel bot deployed to Preview – id-react-dev May 1, 2023 22:37 View deployment

Merge branch 'main' into sharing-state-between-components

e5e9ffa

vercel bot deployed to Preview – id-react-dev May 1, 2023 23:39 View deployment

mhaidarhanif merged commit 0d347ec into reactjs:main May 1, 2023

Conversation

yaffalhakim1 commented Apr 28, 2023 • edited by zainfathoni Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

github-actions bot commented Apr 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

github-actions bot commented Apr 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

github-actions bot commented Apr 29, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

yaffalhakim1 commented Apr 29, 2023

Uh oh!

resir014 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yaffalhakim1 commented Apr 29, 2023

Uh oh!

yaffalhakim1 commented May 1, 2023

Uh oh!

zainfathoni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yaffalhakim1 commented Apr 28, 2023 •

edited by zainfathoni

Loading