docs: translation of Passing Props to a Component#483
Merged
mhaidarhanif merged 10 commits intoreactjs:mainfrom Apr 30, 2023
Merged
docs: translation of Passing Props to a Component#483mhaidarhanif merged 10 commits intoreactjs:mainfrom
Passing Props to a Component#483mhaidarhanif merged 10 commits intoreactjs:mainfrom
Conversation
Contributor
Author
|
Here's some of my note, I'm a bit confuse about what should I translate for |
…inWinando/id.react.dev into passing-props-to-a-component
Collaborator
|
@DevinWinando for string is string. (based on glosary) for thumbnail, let I mention another reviewer @mhaidarhanif @resir014 |
mhaidarhanif
requested changes
Apr 29, 2023
Collaborator
mhaidarhanif
left a comment
There was a problem hiding this comment.
Suggestion, need feedback from @resir014 @mazipan @r17x @zainfathoni
Collaborator
|
@DevinWinando @r17x Let's keep Will be discussed in the glossary thread too. |
- Change translation for pass to 'mengoper' instead of 'mengirim' - Fix title, change it to 'kepada' instead of 'pada'
change to 'ke' instead of 'kepada'
r17x
approved these changes
Apr 30, 2023
Collaborator
|
Wait confirm from @mhaidarhanif |
mhaidarhanif
approved these changes
Apr 30, 2023
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
r17x
pushed a commit
that referenced
this pull request
May 8, 2023
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #428
Translation of Passing Props to a Component
Reference: #330