Skip to content

Translate Writing Markup with JSX#499

Merged
r17x merged 3 commits intoreactjs:mainfrom
mhmmd-ysf:main
May 1, 2023
Merged

Translate Writing Markup with JSX#499
r17x merged 3 commits intoreactjs:mainfrom
mhmmd-ysf:main

Conversation

@mhmmd-ysf
Copy link
Contributor

@mhmmd-ysf mhmmd-ysf commented Apr 29, 2023 •
edited by zainfathoni
Loading

Translate writing-markup-with-jsx.md
Related page: https://react.dev/learn/writing-markup-with-jsx

Closes #419

@mhmmd-ysf mhmmd-ysf mentioned this pull request Apr 29, 2023
Closed
@mhaidarhanif mhaidarhanif changed the title Translate writing-markup-with-jsx.md Translate Writing Markup with JSX Apr 29, 2023
@mhmmd-ysf mhmmd-ysf closed this Apr 29, 2023
@mhmmd-ysf mhmmd-ysf reopened this Apr 29, 2023
mazipan
mazipan reviewed Apr 30, 2023
View reviewed changes
src/content/learn/writing-markup-with-jsx.md Outdated
Kamu dapat membaca uneg-unegku di sini.
<br /><br />
<b>And <i>pictures</i></b> of scientists!
<b>Juga ada <i>foto</b></i> ilmuwan!
Copy link
Collaborator

@mazipan mazipan Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kebalik tag nya.

Suggested change
<b>Juga ada <i>foto</b></i> ilmuwan!
<b>Juga ada <i>foto</i></b> ilmuwan!

Copy link
Contributor Author

@mhmmd-ysf mhmmd-ysf Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kayaknya ini bagian dari latihannya mas? Karena di english juga begitu.

Copy link
Collaborator

@mhaidarhanif mhaidarhanif Apr 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mazipan Itu di dokumentasi sumber merupakan contoh yang sengaja dibuat salah, pembaca disuruh betulin. Jadi sebenarnya terkait tag sudah betul begini. Paling soal kata jamak yang mesti ditingkatkan. Karena sumbernya pictures dan scientists.

Suggested change
<b>Juga ada <i>foto</b></i> ilmuwan!
<b>Juga ada <i>foto-foto</b></i> para ilmuwan!

image

mazipan
mazipan reviewed Apr 30, 2023
View reviewed changes
src/content/learn/writing-markup-with-jsx.md Outdated
</div>
<p className="summary">
You can find my thoughts here.
Kamu dapat membaca uneg-unegku di sini.
Copy link
Collaborator

@mazipan mazipan Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Kamu dapat membaca uneg-unegku di sini.
Anda dapat menemukan pemikiran saya di sini.

Copy link
Collaborator

@mhaidarhanif mhaidarhanif Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wkwk uneg-uneg

src/content/learn/writing-markup-with-jsx.md Outdated
</Sandpack>

Whether to do it by hand or using the converter is up to you!
Kamu bebas untuk mengubah secara manual atau menggunakan *converter*!
Copy link
Collaborator

@mazipan mazipan Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Kamu bebas untuk mengubah secara manual atau menggunakan *converter*!
Apakah melakukan dengan manual atau menggunakan *converter*, terserah pada Anda!

Copy link
Collaborator

@mhaidarhanif mhaidarhanif Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another suggestion to have better reading flow:

Suggested change
Kamu bebas untuk mengubah secara manual atau menggunakan *converter*!
Antara melakukannya dengan manual atau menggunakan *converter*, terserah Anda!

@github-actions
Copy link

github-actions bot commented Apr 30, 2023 •
edited
Loading

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mhaidarhanif mhaidarhanif requested a review from r17x April 30, 2023 21:39
mhaidarhanif
mhaidarhanif approved these changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine but let's wait for the others. @resir014 @r17x @mazipan @zainfathoni

mazipan
mazipan approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@mazipan mazipan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from me, let's ship this!

@r17x r17x merged commit 0e6a711 into reactjs:main May 1, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@mhmmd-ysf @r17x
Translate Writing Markup with JSX (#499)
8ee68e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@mazipan mazipan mazipan approved these changes

@r17x r17x r17x approved these changes

@resir014 resir014 Awaiting requested review from resir014

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Writing Markup with JSX

4 participants

@mhmmd-ysf @mhaidarhanif @mazipan @r17x