docs(translation): translate useImperativeHandle#518
Merged
mhaidarhanif merged 15 commits intoreactjs:mainfrom Jun 8, 2023
agustinusnathaniel:docs_api_use_imperative_handle
Merged
docs(translation): translate useImperativeHandle#518mhaidarhanif merged 15 commits intoreactjs:mainfrom agustinusnathaniel:docs_api_use_imperative_handle
useImperativeHandle#518mhaidarhanif merged 15 commits intoreactjs:mainfrom
agustinusnathaniel:docs_api_use_imperative_handle
Conversation
mazipan
reviewed
May 3, 2023
mazipan
approved these changes
May 3, 2023
Collaborator
mazipan
left a comment
There was a problem hiding this comment.
Looks good to me 🟢, let's wait for review from @mhaidarhanif, @r17x @resir014 or @zainfathoni
resir014
previously requested changes
May 3, 2023
r17x
approved these changes
May 3, 2023
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
zainfathoni
requested changes
May 3, 2023
Collaborator
There was a problem hiding this comment.
I have a few more suggestions while introducing more words to the glossary.
Let's discuss them over here: #337 (comment)
| <Pitfall> | ||
|
|
||
| **Do not overuse refs.** You should only use refs for *imperative* behaviors that you can't express as props: for example, scrolling to a node, focusing a node, triggering an animation, selecting text, and so on. | ||
| **Jangan terlalu sering menggunakan refs.** Anda hanya boleh menggunakan *refs* untuk perilaku *imperatif* yang tidak dapat Anda ungkapkan sebagai *props*: misalnya, menggulir ke sebuah *node*, memfokuskan sebuah *node*, memicu sebuah animasi, memilih teks, dan sebagainya. |
Collaborator
There was a problem hiding this comment.
Suggested change
| **Jangan terlalu sering menggunakan refs.** Anda hanya boleh menggunakan *refs* untuk perilaku *imperatif* yang tidak dapat Anda ungkapkan sebagai *props*: misalnya, menggulir ke sebuah *node*, memfokuskan sebuah *node*, memicu sebuah animasi, memilih teks, dan sebagainya. | |
| **Jangan terlalu sering menggunakan refs.** Anda hanya boleh menggunakan *refs* untuk perilaku *imperatif* yang tidak dapat Anda ungkapkan sebagai *props*: misalnya, menggulir ke sebuah simpul, memfokuskan sebuah simpul, memicu sebuah animasi, memilih teks, dan sebagainya. |
- Translate
node. Glossary
Contributor
Author
|
Hi @resir014 @zainfathoni thank you so much for the review and suggestions, updated 🙏 |
Collaborator
|
Need to re-check @zainfathoni @resir014 |
Co-authored-by: Resi Respati <resir014@gmail.com>
Collaborator
|
Help to re-review @zainfathoni @resir014 |
Contributor
Author
|
Hi @zainfathoni @resir014 need help to re-review 🙇 🙏 |
mazipan
approved these changes
May 31, 2023
Collaborator
|
Merging is blocked @resir014 @zainfathoni |
zainfathoni
approved these changes
May 31, 2023
Collaborator
zainfathoni
left a comment
There was a problem hiding this comment.
LGTM 💯
Thanks for making the changes and sorry for the delayed review. 🙏
Collaborator
|
@resir014, your call |
mhaidarhanif
approved these changes
Jun 8, 2023
FelixFern
pushed a commit
to FelixFern/id.react.dev
that referenced
this pull request
Jun 13, 2023
Co-authored-by: Resi Respati <resir014@gmail.com> Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #403
Description
Translate the
useImperativeHandlepage.Page URL: https://id.react.dev/reference/react/useImperativeHandle