Merged
Conversation
r17x
requested changes
May 1, 2023
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
zainfathoni
requested changes
May 1, 2023
Collaborator
There was a problem hiding this comment.
More terms to introduce in the glossary, @resir014 @r17x @mhaidarhanif @mazipan
| English | Indonesian |
|---|---|
| hardcode | kode keras (?), menuliskan secara langsung di dalam kode |
| server rendering | pe-render-an pada server |
| prefix | awalan |
| suffix | akhiran |
Let's discuss them here: #337 (comment)
src/content/reference/react/useId.md
Outdated
| #### Caveats {/*caveats*/} | ||
|
|
||
| * `useId` is a Hook, so you can only call it **at the top level of your component** or your own Hooks. You can't call it inside loops or conditions. If you need that, extract a new component and move the state into it. | ||
| * `useId` adalah sebuah Hook, jadi Anda hanya dapat memanggilnya **di tingkat atas komponen Anda** atau Hook Anda sendiri. Anda tidak dapat memanggilnya di dalam loop atau kondisi. Jika Anda membutuhkannya, ekstrak komponen baru dan pindahkan *state* ke dalamnya. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * `useId` adalah sebuah Hook, jadi Anda hanya dapat memanggilnya **di tingkat atas komponen Anda** atau Hook Anda sendiri. Anda tidak dapat memanggilnya di dalam loop atau kondisi. Jika Anda membutuhkannya, ekstrak komponen baru dan pindahkan *state* ke dalamnya. | |
| * `useId` adalah sebuah Hook, jadi Anda hanya dapat memanggilnya **di tingkat teratas komponen Anda** atau Hook Anda sendiri. Anda tidak dapat memanggilnya di dalam perulangan (*loops*) atau kondisi (*conditions*). Jika Anda membutuhkannya, ekstrak komponen baru dan pindahkan *state* ke dalamnya. |
src/content/reference/react/useId.md
Outdated
| ``` | ||
|
|
||
| However, hardcoding IDs like this is not a good practice in React. A component may be rendered more than once on the page--but IDs have to be unique! Instead of hardcoding an ID, generate a unique ID with `useId`: | ||
| Namun, memaksakan ID seperti ini bukanlah praktik yang baik di React. Sebuah komponen dapat dirender lebih dari sekali pada halaman—namun ID harus unik! Alih-alih melakukan pemaksaan ID, buat ID unik dengan `useId`: |
Collaborator
There was a problem hiding this comment.
Suggested change
| Namun, memaksakan ID seperti ini bukanlah praktik yang baik di React. Sebuah komponen dapat dirender lebih dari sekali pada halaman—namun ID harus unik! Alih-alih melakukan pemaksaan ID, buat ID unik dengan `useId`: | |
| Namun, menuliskan ID secara langsung di dalam kode (*hardcoding*) seperti ini bukanlah praktik yang baik di React. Sebuah komponen dapat dirender lebih dari sekali pada halaman—namun ID harus unik! Alih-alih melakukan pemaksaan ID, bangkitkan sebuah ID unik dengan `useId`: |
src/content/reference/react/useId.md
Outdated
| <Pitfall> | ||
|
|
||
| With [server rendering](/reference/react-dom/server), **`useId` requires an identical component tree on the server and the client**. If the trees you render on the server and the client don't match exactly, the generated IDs won't match. | ||
| Dengan [rendering server](/reference/react-dom/server), **`useId` membutuhkan pohon komponen yang identik di server dan klien**. Jika pohon yang Anda render di server dan klien tidak sama persis, ID yang dihasilkan tidak akan cocok. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Dengan [rendering server](/reference/react-dom/server), **`useId` membutuhkan pohon komponen yang identik di server dan klien**. Jika pohon yang Anda render di server dan klien tidak sama persis, ID yang dihasilkan tidak akan cocok. | |
| Dengan [pe-*render*-an pada *server*](/reference/react-dom/server), **`useId` membutuhkan pohon komponen yang identik di *server* dan klien**. Jika pohon yang Anda *render* di *server* dan klien tidak sama persis, ID yang dihasilkan tidak akan cocok. |
Contributor
Author
There was a problem hiding this comment.
I didn't fix it because the word pe-*render*-an is still under discussion
r17x
approved these changes
May 3, 2023
Collaborator
|
Need to re-check @zainfathoni |
mazipan
approved these changes
May 8, 2023
Collaborator
|
Waiting your approval, @zainfathoni |
Collaborator
|
Okay, I'll review it tonight. |
zainfathoni
requested changes
May 8, 2023
Collaborator
zainfathoni
left a comment
There was a problem hiding this comment.
Thanks for addressing some of my previously requested changes.
Here is another review of the unaddressed change requests.
Collaborator
|
@zainfathoni need to recheck latest changes |
Member
|
@zainfathoni do you have time for re-review? |
Collaborator
Yes, I will have some time to review this weekend. Sorry for the delay. 🙏 |
zainfathoni
approved these changes
Jul 30, 2023
Collaborator
zainfathoni
left a comment
There was a problem hiding this comment.
Approved with a minor suggestion. 💯
Thanks for making the requested changes! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #402
Description
Translate the useId page.
Page URL: https://id.react.dev/reference/react/useId