docs: translate react-dom -> flushSync#578
Merged
mazipan merged 6 commits intoreactjs:mainfrom Jun 22, 2023
aris-uu:main
Merged
docs: translate react-dom -> flushSync#578mazipan merged 6 commits intoreactjs:mainfrom aris-uu:main
react-dom -> flushSync#578mazipan merged 6 commits intoreactjs:mainfrom
aris-uu:main
Conversation
resir014
reviewed
Jun 18, 2023
Member
resir014
left a comment
There was a problem hiding this comment.
First pass of review, here are some requested changes.
Tagging other maintainers for additional review @mhaidarhanif @zainfathoni @mazipan.
mazipan
reviewed
Jun 18, 2023
Co-authored-by: Resi Respati <resir014@gmail.com>
Collaborator
mhaidarhanif
left a comment
There was a problem hiding this comment.
Some improvements.
(This is a "comment" so it won't block like "request changes")
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
mhaidarhanif
approved these changes
Jun 21, 2023
Collaborator
mhaidarhanif
left a comment
There was a problem hiding this comment.
Approve for now
There's an idea to translate "flush" to "bilas" / "membilas" / "dibilas"
We'll wait for the others @resir014 @mazipan @zainfathoni @r17x
resir014
approved these changes
Jun 21, 2023
Member
resir014
left a comment
There was a problem hiding this comment.
All good on my end. Thanks! 💙
react-dom -> flushSync
react-dom -> flushSyncreact-dom -> flushSync
mazipan
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #438
Description
Translate the
flushSyncpage.Page URL: https://id.react.dev/reference/react-dom/flushSync