Skip to content

docs: translate Suspense page#601

Merged
resir014 merged 20 commits intoreactjs:mainfrom
chez14:chez14/translate-suspense
Apr 8, 2024
Merged

docs: translate Suspense page#601
resir014 merged 20 commits intoreactjs:mainfrom
chez14:chez14/translate-suspense

Conversation

@chez14
Copy link
Contributor

@chez14 chez14 commented Jul 30, 2023

Fixes #416 and closes #523

Description

This PR adds translation to "Suspense" page, continuing @maulanasdqn effort.

Translate the Suspense page.
Page URL:

@github-actions
Copy link

github-actions bot commented Jul 30, 2023 •
edited
Loading

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@chez14
Copy link
Contributor Author

chez14 commented Aug 6, 2023 •
edited
Loading

I'm having hard time translating these terms:

  • Suspend → Ditangguhkan?
  • Fallback → fallback
  • Boundary → Batasan
  • Lazy-loading → Lazy-load

For now, I'll take notes on all of these terms and will consult while submitting this PR for review.

@resir014
Copy link
Member

resir014 commented Aug 21, 2023

Suspend → Ditangguhkan?
Fallback → fallback
Boundary → Batasan
Lazy-loading → Lazy-load

Yep, all these should be correct. @chez14

@chez14
Copy link
Contributor Author

chez14 commented Aug 21, 2023 •
edited
Loading

I got quite busy past few weeks, I'm targeting to finish this MR/PR by this week.

@chez14 chez14 force-pushed the chez14/translate-suspense branch from d716969 to 7174d59 Compare August 26, 2023 11:16
@chez14 chez14 marked this pull request as ready for review August 26, 2023 11:16
@chez14 chez14 force-pushed the chez14/translate-suspense branch from 7174d59 to ec22cb1 Compare August 26, 2023 11:20
@chez14
Copy link
Contributor Author

chez14 commented Aug 26, 2023

Hi @resir014 and @zainfathoni,

This PR is ready for review, please let me know if you have any feedback.

Thank you!

Hi @maulanasdqn,

Thank you for the initial translation work. As most of the work were done by you, I think it's fair to ask for your feedback too when you're able to review the PR haha.

Thank you!

@chez14 chez14 mentioned this pull request Sep 2, 2023
Closed
@resir014 resir014 self-requested a review September 8, 2023 15:35
@resir014
Copy link
Member

resir014 commented Sep 10, 2023

@chez14 Sorry for the delay, I can help in tagging the reviewers for now. @mhaidarhanif @zainfathoni @mazipan @r17x

mhaidarhanif
mhaidarhanif requested changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review with suggestion

mhaidarhanif
mhaidarhanif previously requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions.

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Sep 13, 2023

@chez14 Just reviewed with some more suggestions.

cc @resir014 @zainfathoni @r17x @mazipan

@resir014
Copy link
Member

resir014 commented Oct 12, 2023

Hi, any updates to this? @chez14

@chez14
Copy link
Contributor Author

chez14 commented Oct 17, 2023

Ah sorry, i missed this notification. I've been quite busy with office work lately, I'll try to update this PR by this week.

Thank you!

@resir014
Copy link
Member

resir014 commented Nov 5, 2023

@chez14 Hi, are you still able to work on this? If you're unable to work on this within the next 3-5 days, we can take over your PRs.

@maulanasdqn
Copy link
Contributor

maulanasdqn commented Jan 13, 2024 •
edited
Loading

@resir014 can i continue this work? cc @chez14

@resir014
Copy link
Member

resir014 commented Jan 14, 2024

Yes, feel free to pick up this PR! @maulanasdqn

@resir014 @mhaidarhanif
Apply suggestions from code review
60406b7 
Co-authored-by: M Haidar Hanif <me@mhaidarhanif.com>
@vercel
Copy link

vercel bot commented Apr 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
id-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 2:20am

@resir014 @mhaidarhanif
Apply suggestions from code review
eed444a 
Co-authored-by: M Haidar Hanif <me@mhaidarhanif.com>
@resir014 resir014 requested a review from mhaidarhanif April 8, 2024 02:20
@resir014
Copy link
Member

resir014 commented Apr 8, 2024

Picking this up again since we need to get the remaining pages translated since we have some other new pages to translate.

@resir014 resir014 dismissed mhaidarhanif’s stale review April 8, 2024 03:48

Suggested changes applied.

@resir014 resir014 merged commit bf6628f into reactjs:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014 resir014 resir014 approved these changes

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

@mazipan mazipan Awaiting requested review from mazipan

@r17x r17x Awaiting requested review from r17x

@mhaidarhanif mhaidarhanif Awaiting requested review from mhaidarhanif

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<Suspense>

4 participants

@chez14 @resir014 @mhaidarhanif @maulanasdqn