Translate useExternalStore reference#619
Merged
koba04 merged 3 commits intoreactjs:mainfrom Jul 17, 2023
Merged
Conversation
smikitky
requested changes
Jul 15, 2023
Member
smikitky
left a comment
There was a problem hiding this comment.
レビューを行いましたので対応をお願いします。
ChatGPT を信用せず、全文丁寧に添削する方向でお願いします。訳抜けやタグ抜け、明らかな誤訳が結構放置されています。またローカルで dev server を立ち上げて、そもそもちゃんとページの表示ができているかの確認をお願いします。
Contributor
Author
|
@smikitky
お手数おかけしますが、再度レビューお願いします。 |
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
smikitky
requested changes
Jul 15, 2023
Member
smikitky
left a comment
There was a problem hiding this comment.
ありがとうございます。ほぼ OK なのですが幾つか私の方で見逃しがあったので対応をお願いします:pray:
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Contributor
Author
|
レビュー、ありがとうございます！ 71ea816 で code suggestion を squash して push -f して反映しました。 よろしくお願いします🙏 |
smikitky
approved these changes
Jul 15, 2023
Member
|
ありがとうございました！ 2 名が approve してからのマージになりますのでしばらくお待ちください。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useExternalStoreの翻訳ですやったこと