Merged
Conversation
ainoshment
commented
Jul 27, 2023
smikitky
requested changes
Aug 2, 2023
Member
smikitky
left a comment
There was a problem hiding this comment.
幾つかの修正と、読みやすくするための suggestion を行いましたので確認をお願いします。
| `<select>` は[一般的な要素の props](/reference/react-dom/components/common#props) をすべてサポートしています。 | ||
|
|
||
| You can [make a select box controlled](#controlling-a-select-box-with-a-state-variable) by passing a `value` prop: | ||
| `value` プロパティを渡すことで、[セレクトボックスを制御](#controlling-a-select-box-with-a-state-variable)できます。 |
Member
There was a problem hiding this comment.
Suggested change
| `value` プロパティを渡すことで、[セレクトボックスを制御](#controlling-a-select-box-with-a-state-variable)できます。 | |
| `value` プロパティを渡すことで、[セレクトボックスを制御されたコンポーネント (controlled component)](#controlling-a-select-box-with-a-state-variable) にできます。 |
訳語統一です
Contributor
Author
|
@smikitky （修正箇所が多くて😓）お手数をおかけしました...！修正を行いましたのでご確認よろしくお願いします！ |
smikitky
approved these changes
Aug 8, 2023
Member
|
ありがとうございました。1箇所だけスタイルの問題を追加で修正させていただきました(3a4613c)。 |
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
koba04
requested changes
Aug 27, 2023
Member
koba04
left a comment
There was a problem hiding this comment.
@ainoshment
レビューありがとうございます！一点、Markdown フォーマットの修正だけ提案したので確認お願いします！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-dom: Componentsの<select>の翻訳です。