Conversation
added 19 commits
February 24, 2019 20:51
|
Deploy preview for ko-reactjs-org ready! Built with commit 0a9011d |
gnujoow
reviewed
May 6, 2019
content/tutorial/tutorial.md
Outdated
| ## 자습서를 시작하기 전에 {#before-we-start-the-tutorial} | ||
|
|
||
| We will build a small game during this tutorial. **You might be tempted to skip it because you're not building games -- but give it a chance.** The techniques you'll learn in the tutorial are fundamental to building any React apps, and mastering it will give you a deep understanding of React. | ||
| 우리는 자습서에서 작은 게임을 만들 것입니다. **게임을 만들고 싶지 않기 때문에 자습서를 건너뛰고 싶을 수 있습니다 -- 그래도 기회를 주세요.** 자습서에서 배우는 기술은 React 앱을 만드는 데 있어 기본이며 그것을 마스터하면 React에 대해 깊이 이해할 수 있습니다. |
Member
There was a problem hiding this comment.
우리는 이 자습서에서 작은 게임을 만들것입니다. 게임을 만들고 싶지 않아서 자습서를 건너뛰고 싶을 수 있습니다. 그래도 한번 해보세요! 자습서를 통해 React앱을 만드는 기본적인 사항들을 배웁니다. 이것을 마스터하면 React를 더 깊게 이해할 수 있습니다.
로 순화하면 어떨까요?
gnujoow
requested changes
May 6, 2019
Member
gnujoow
left a comment
There was a problem hiding this comment.
앞부분 번역만 살펴보았는데 전체적으로 번역투 느낌이 많이 납니다. 한번 쭉 읽어보시고 순화해보면 어떨까요?
content/tutorial/tutorial.md
Outdated
| * [Overview](#overview) will teach you **the fundamentals** of React: components, props, and state. | ||
| * [Completing the Game](#completing-the-game) will teach you **the most common techniques** in React development. | ||
| * [Adding Time Travel](#adding-time-travel) will give you **a deeper insight** into the unique strengths of React. | ||
| * [자습서 설정](#setup-for-the-tutorial)은 자습서를 따를 수 있는 **시작점**을 안내합니다. |
Member
There was a problem hiding this comment.
자습서 설정 은 적절한 번역이 아닌것 같습니다. 원문을 살펴보고 다른 번역을 제시해주시면 좋을것 같아요
Author
There was a problem hiding this comment.
외래어 표기는 지양하려고 했는데 자습서 세팅 이 나을까요, 아니면 준비 나 시작하기 처럼 의역을 하는게 나을까요?
hg-pyun
reviewed
May 15, 2019
Author
|
수정사항 반영하여 업데이트 했습니다. 부자연스러운 부분 있으면 언제든지 알려주세요 :) |
hg-pyun
previously approved these changes
Jun 2, 2019
taehwanno
approved these changes
Jun 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for delay 😅
Progress