Skip to content

translating "testing-environments.md" to Korean #183

Merged
taehwanno merged 18 commits intoreactjs:masterfrom
BeomYoung:master
May 10, 2020
Merged

translating "testing-environments.md" to Korean #183
taehwanno merged 18 commits intoreactjs:masterfrom
BeomYoung:master

Conversation

@BeomYoung
Copy link
Contributor

@BeomYoung BeomYoung commented Nov 7, 2019 •
edited
Loading

@netlify
Copy link

netlify bot commented Nov 7, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit c3891da

https://deploy-preview-183--ko-reactjs-org.netlify.app

@tesseralis tesseralis mentioned this pull request Nov 8, 2019
Open
@taehwanno
Copy link
Member

taehwanno commented Nov 8, 2019

풀 리퀘스트 설명에 적혀있는 각 단계를 확인하시고 완료 하셨다면 체크 부탁드릴게요 ㅎㅎ

@gnujoow
Copy link
Member

gnujoow commented Nov 12, 2019 •
edited
Loading

@BeomYoung
모든 문장을 문서의 내용이 친근하게 다가올 수 있도록 경어체로 변경해주시면 감사하겠습니다.

cc @taehwanno
#2 (comment)

해당내용을 공통 스타일 가이드에 추가하려는데 괜찮을까요?

@taehwanno
Copy link
Member

taehwanno commented Nov 14, 2019

해당내용을 공통 스타일 가이드에 추가하려는데 괜찮을까요?

@gnujoow 공통 스타일 가이드라면 UNIVERSLA-STYLE-GUIDE.md를 의미하시는 걸까요? 해당 문서는 reactjs/reactjs.org-translation 저장소의 style-guide.md를 번역한 문서라 모범 사례 위키에 추가하는게 더 좋아보여요 ㅎㅎ

@BeomYoung
Copy link
Contributor Author

BeomYoung commented Nov 19, 2019

@gnujoow 말씀해주신대로 경어체로 수정 완료했습니다!

@BeomYoung
Copy link
Contributor Author

BeomYoung commented Nov 19, 2019

@taehwanno 제일 상단의 표의 내용도 번역을 진행하는 게 좋을까요?

id : testing-environments
title : Testing Environments
permalink : docs/testing-environments.html
prev : testing-recipes.html

@gnujoow
Copy link
Member

gnujoow commented Nov 19, 2019

@BeomYoung 상단 yaml 내용중에서 title내용만 번역 부탁드립니다

@gnujoow
Copy link
Member

gnujoow commented Nov 19, 2019

@BeomYoung
문단의 각 제목에는 id가 포함되어있습니다. 아래 문서와 pr 템플릿의 문서들을 읽어주시고 수정 부탁드립니다.
https://github.com/reactjs/ko.reactjs.org/blob/master/UNIVERSAL-STYLE-GUIDE.md#%EC%A0%9C%EB%AA%A9-%EC%95%84%EC%9D%B4%EB%94%94

@BeomYoung
Copy link
Contributor Author

BeomYoung commented Nov 19, 2019

@gnujoow 수정 완료했습니다. 확인 부탁드립니다

gnujoow
gnujoow requested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문서의 markdown 문법들이 모두 누락되어 있습니다. 아래 링크를 확인하셔서 누락된 markdown 문법들을 모두 추가해주세요.

https://ko.wikipedia.org/wiki/%EB%A7%88%ED%81%AC%EB%8B%A4%EC%9A%B4

@BeomYoung
Copy link
Contributor Author

BeomYoung commented Nov 19, 2019

@gnujoow 수정했습니다!

@BeomYoung BeomYoung requested a review from gnujoow November 20, 2019 14:44
taehwanno
taehwanno requested changes Nov 30, 2019
View reviewed changes
@BeomYoung
Copy link
Contributor Author

BeomYoung commented Dec 1, 2019

@taehwanno 수정하신 내용 전부 확인했습니다! 감사합니다

taehwanno
taehwanno approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 피드백 드린 거랑 원문 비교했을 때 수정해야할 부분 몇 가지 보여서 직접 처리했습니다! 고생하셨습니다.

@taehwanno taehwanno merged commit 4cb7f9a into reactjs:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taehwanno taehwanno taehwanno approved these changes

@gnujoow gnujoow Awaiting requested review from gnujoow

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BeomYoung @taehwanno @gnujoow @hg-pyun