Translate HOOKS > Hooks API Reference#89

Merged

taehwanno merged 12 commits intoreactjs:masterfrom

hapumee:master

Apr 28, 2019

Contributor

hapumee commented Apr 2, 2019 •

edited by hg-pyun

Loading

Progress

번역 초안 작성 (Draft translation)
공통 스타일 가이드 확인 (Check the common style guide)
모범사례 확인 (Check best practices)
용어 확인 (Check the term)
맞춤법 검사 (Spelling check)
리뷰 반영 (Resolve reviews)


          Draft translation

53734cf

hapumee changed the title ~~Draft translation~~ Translate HOOKS > Hooks API Reference

netlify bot commented Apr 2, 2019 •

edited

Loading

Deploy preview for ko-reactjs-org ready!

Built with commit 69c6a8f

https://deploy-preview-89--ko-reactjs-org.netlify.com

tesseralis mentioned this pull request

Korean Translation Progress #1

Open

taehwanno added the needs review label

Contributor Author

hapumee commented Apr 3, 2019

I'm not sure how I can translate the terms below.
If there are words which have already been decided for them, just let me know.
I'm gonna fix them.

effect : effect
clean-up/ clean-up function : 정화 함수
flush : 해결, 발생
memoization : 메모화, 저장화
signature : 시그니처
mutation : 변경
fire : 발생하다
DevTools : 개발자도구
mutable : 변경 가능한, 가변의
customize : 사용자화하다
lazy : 지연
reducer : reducer

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved


          [review #1]

597320d

1) line 13 "혹 Hook이" -> "Hook이"
2) line 52 "함수 갱신" -> "함수적 갱신"

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

youngsunmin and others added 2 commits

April 12, 2019 14:33


          [review 2]

4c32d11

1) line 74
2) line 83
3) line 87
4) line 98
5) line 108


          Merge branch 'master' into master

b91d379

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

youngsunmin added 3 commits

April 17, 2019 19:25


          [review 3]

cca6fcc

1) line 110
2) line 112
3) line 114
4) line 116


          Merge remote-tracking branch 'origin/master'

535cccc


          [review] '재 렌더링' 및 '재렌더링' 변경 -> '리렌더링'

1d18e63

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/hooks-reference.md Outdated Show resolved Hide resolved

simsim0709 added needs author response and removed needs review labels

Collaborator

simsim0709 commented Apr 23, 2019

리뷰 다 마쳤습니다. 확인 부탁드려요. 😄


          [review] 커맨트된 부분 수정

58f51ca

simsim0709 self-requested a review

April 24, 2019 08:17

simsim0709 approved these changes

View reviewed changes

Collaborator

simsim0709 left a comment

정말 수고 많으셨어요~ 👍

simsim0709 requested a review from taehwanno

April 24, 2019 08:17

simsim0709 added needs +1 approval and removed needs author response labels


          Merge branch 'master' into master

a4a62a4

Contributor Author

hapumee commented Apr 24, 2019

커맨트 주신 부분 모두 반영하였습니다.
"needs author response"로 label이 변경되어, 커맨트 conversation은 제가 resolve 했습니다. : )

다만, 한 가지, line 195에 대한 의견을 드렸는데요,
한 번 확인 부탁드릴께요. 보시고서 resolve 해 주시면 좋을 것 같습니다. : )

Contributor Author

hapumee commented Apr 24, 2019 •

edited

Loading

아.. 그렇다면 하나 남아 있던 conversation도 제가 resolve 하겠습니다. ^_________^

좋은 논의였습니다. 감사합니다. : )

hg-pyun approved these changes

View reviewed changes

Member

hg-pyun left a comment

고생하셨습니다.

hg-pyun added ready to merge and removed needs +1 approval labels

hg-pyun added 3 commits

April 24, 2019 20:46


          Merge branch 'master' into master

6e96b18


          Merge branch 'master' into master

9ee2bed


          Merge branch 'master' into master

69c6a8f

taehwanno merged commit 0912d04 into reactjs:master

Member

taehwanno commented Apr 28, 2019

고생하셨습니다!

taehwanno removed the ready to merge label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet