Update travis config to test againt 7.0, 7.1, and nightly#56
Closed
siwinski wants to merge 1 commit intoreactphp:masterfrom
Closed
Update travis config to test againt 7.0, 7.1, and nightly#56siwinski wants to merge 1 commit intoreactphp:masterfrom
siwinski wants to merge 1 commit intoreactphp:masterfrom
Conversation
jsor
approved these changes
Mar 17, 2017
WyriHaximus
approved these changes
Mar 17, 2017
clue
reviewed
Mar 23, 2017
| - 7 | ||
| - 7.0 | ||
| - 7.1 | ||
| - nightly |
Member
There was a problem hiding this comment.
Will this library continue to work once a nightly contains breaking changes or PHP 8 or PHP 9 will be released? I'm not sure we can guarantee this, so I would rather remove the "nightly" build here.
Also, I would vote to not merge this yet at least until the issues with PHP 7.1 are resolved 👍
Member
There was a problem hiding this comment.
We could move nightly to allowed to fail so we know if it works on PHP 8 and PHP 9 before it comes out 😄
Member
There was a problem hiding this comment.
Makes sense, either that or removing it altogether 👍
Author
There was a problem hiding this comment.
Sorry for the delay. I updated the changes to allow nightly failures. I have not had time to fix the test suite for 7.1 though.
c884302 to
0646f1b
Compare
This was referenced Aug 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to the PHP 7.1 failures reported in #55
I will try to submit a fix for the failures when I get time unless someone else gets to fixing the failures before I do.