Work around DNS timeout issues for Windows users#74
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Aug 9, 2017
Merged
Work around DNS timeout issues for Windows users#74WyriHaximus merged 1 commit intoreactphp:masterfrom
WyriHaximus merged 1 commit intoreactphp:masterfrom
Conversation
jsor
approved these changes
Aug 9, 2017
WyriHaximus
approved these changes
Aug 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain PHP versions on Windows require to read the full incoming receive buffer. This is actually a bug in PHP for Windows only that was fixed with PHP 7.0.17 and PHP 7.1.3.
This PR re-introduces the work-around that already landed with #53 but was later disabled by updating the socket version with #61. This temporary work-around works for all versions across all platforms, so it doesn't really hurt. Ultimately, this will be resolved once #12 lands in the next major version.
See also https://bugs.php.net/bug.php?id=74090 and php/php-src@89a5bd6.
Builds on top of #73
Resolves / closes #63