Conversation
To reduce cyclic dependency between the two, as it is only used in tests
composer.json
Outdated
| "react/stream": "^1.0 || ^0.7 || ^0.6 || ^0.5 || ^0.4.5" | ||
| }, | ||
| "require-dev": { | ||
| "react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5 || ^0.4.4", |
There was a problem hiding this comment.
In that case there's no reason to keep the old versions here.
clue
left a comment
There was a problem hiding this comment.
Thanks for filing this ticket @cboden!
I'm not opposed to get this in, as I agree that this cyclic dependency is annoying and something I'd rather get rid of.
However, given that this dependency will be needed once #19 is in (soonish), I'm unsure how much value this PR provides.
Installation instructions have been added recently in #71, perhaps we could also somehow provide the default value to composer as an alternative?
I'll leave the decision up to you guys, I'm good with either getting this in for now and reverting this soonish or looking into the default for composer 👍
|
I wasn't aware of #19. No point in merging this if it's just going to be undone soonish. |
To reduce cyclic dependency between the two, as it is only used in tests