Removed testing against HHVM nightly#66
Merged
WyriHaximus merged 3 commits intomasterfrom Nov 30, 2016
Merged
Conversation
Member
Author
Member
|
👍 |
Member
|
Perhaps I'm missing something, but what is the point in adding PHP 7.1 here? Afaict there are no BC breaks and nothing we take advantage of in particular, so should we really keep adding new versions to our ever growing test matrix? Also, what about our other components? 👍 on dropping unsupported/broken hhvm-nightly builds |
Member
Author
|
Right the addition of 7.1 is a force of habit of always testing against all supported versions. I'm +-0 on it to be honest so if anyone insists on not testing against it that is fine by me since we also test against 7.0. |
WyriHaximus
added a commit
to WyriHaximus/http
that referenced
this pull request
May 31, 2017
* Test against PHP 7.1 and not against HHVM nightly anymore * Removed 7.1 to not overly bloat the test matrix * Changed 7.0 back to 7 so the effective changes are only what the PR is about now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HHVM is broken on travis for a while now.