Ignore excessive whitespace in chunk header#116
Closed
DangerLifter wants to merge 2 commits intoreactphp:masterfrom
Closed
Ignore excessive whitespace in chunk header#116DangerLifter wants to merge 2 commits intoreactphp:masterfrom
DangerLifter wants to merge 2 commits intoreactphp:masterfrom
Conversation
|
Hey thank you for your PR 👍 While I see your problem, I am pretty sure that a Any idea how other clients handle this behavior? |
Author
Sorry, know nothing here.
Done. |
7682fe3 to
1f050d9
Compare
clue
requested changes
Jan 16, 2018
Member
clue
left a comment
There was a problem hiding this comment.
@DangerLifter Thank you for looking into this and filing this PR! 👍
I've found some minor issues below, I'm happy to get this in once this PR is updated 
| ], | ||
| 'extra-space-in-length-chunk' => [ | ||
| ["04 \r\nWiki\r\n5\r\npedia\r\nE\r\n in\r\n\r\nchunks.\r\n0\r\n\r\n"], | ||
| ] |
Member
There was a problem hiding this comment.
Minor CS issue.
Also, can you add a test a chunk header that consists of a single space " \r\n" will be rejected?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#115